Yaml linter execution and config improved

Change-Id: I226d9cd1dd712b8277db85037276f587be22e9f1

service/horizon.yaml

@@ -9,10 +9,10 @@ service:
         readiness: "true"
         liveness: "true"
       volumes:
-      - name: horizon-logs
-        path: "/var/log/ccp/horizon"
-        type: host
-        readOnly: False
+        - name: horizon-logs
+          path: "/var/log/ccp/horizon"
+          type: host
+          readOnly: False
       pre:
         - name: chown-logs-dir
           command: "sudo /bin/chown horizon:horizon /var/log/ccp/horizon"

tools/run-check-yaml-syntax.sh

@@ -1,7 +0,0 @@
-#!/bin/bash
-
-### Temp yaml syntax checker script.
-set -e
-for file in $(find . -name '*.yaml'); do
-    yamllint -d relaxed $file
-done

tools/yamllint.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+set -ex
+
+workdir=$(dirname $0)
+yamllint -c $workdir/yamllint.yaml $(find . -not -path '*/\.*' -type f -name '*.yaml')

tools/yamllint.yaml

@@ -0,0 +1,21 @@
+extends: default
+
+rules:
+  braces:
+    max-spaces-inside: 1
+  comments:
+    level: error
+  comments-indentation:
+    level: warning
+  document-end:
+    present: no
+  document-start:
+    level: error
+    present: no
+  empty-lines:
+    max: 1
+    max-start: 0
+    max-end: 0
+  line-length:
+    level: warning
+    max: 120

tox.ini

@@ -6,7 +6,7 @@ skipsdist = True
 [testenv:linters]
 deps = yamllint
 commands =
-    {toxinidir}/tools/run-check-yaml-syntax.sh
+    {toxinidir}/tools/yamllint.sh
 
 [testenv:bashate]
 deps = bashate>=0.2