x
/
fuel-ccp
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(2 comments)

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 13478 2016-10-14 08:28:16 +00:00 committed by Gerrit Code Review
parent dcafce1299
commit 8376dbca2b
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
866357759bf39ed7215f05914b8259c79d0a75bb Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"key": {
"uuid": "fa6399be_a82db5a9",
"filename": "fuel_ccp/fernet_utils.py",
"patchSetId": 1
},
"lineNbr": 73,
"author": {
"id": 13478
},
"writtenOn": "2016-10-14T08:28:16Z",
"side": 1,
"message": "in python3 .sort method was removed. Instead of it, sorted() should be used. Like this:\n\n number_keys \u003d sorted(number_keys, key\u003dint)",
"range": {
"startLine": 73,
"startChar": 4,
"endLine": 73,
"endChar": 29
},
"revId": "866357759bf39ed7215f05914b8259c79d0a75bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa6399be_a3ef96e7",
"filename": "fuel_ccp/fernet_utils.py",
"patchSetId": 1
},
"lineNbr": 77,
"author": {
"id": 13478
},
"writtenOn": "2016-10-14T08:28:16Z",
"side": 1,
"message": "in python3 this won\u0027t work because number_keys has type \"dict_keys\". number_keys need to become list first.",
"range": {
"startLine": 77,
"startChar": 4,
"endLine": 77,
"endChar": 39
},
"revId": "866357759bf39ed7215f05914b8259c79d0a75bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}