Update patch set 1

Patch Set 1:

(2 comments)

Thanks, Oleksandr.  I have questions about two of your comments, inline.

Everything else is fine, and I will be happy to make those changes.

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 13734 2016-04-22 13:25:45 +00:00 committed by Gerrit Code Review
parent 0d0149ad96
commit 7a29fab47a
1 changed files with 48 additions and 0 deletions

View File

@ -207,6 +207,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_f5739de5",
"filename": "doc/source/calico-fuel-plugin-2.0.rst",
"patchSetId": 1
},
"lineNbr": 123,
"author": {
"id": 13734
},
"writtenOn": "2016-04-22T13:25:45Z",
"side": 1,
"message": "Oleksandr, I\u0027m not sure what you mean here. What is the verification that you think should be done _before_ deployment?",
"parentUuid": "1a122d0e_694ea3c2",
"range": {
"startLine": 123,
"startChar": 11,
"endLine": 123,
"endChar": 62
},
"revId": "d0b3c196bbd3f0b08df66ece24fba1b1f7ea3d57",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_69db431c",
@ -252,6 +276,30 @@
"revId": "d0b3c196bbd3f0b08df66ece24fba1b1f7ea3d57",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a122d0e_e83d84bc",
"filename": "doc/source/index.rst",
"patchSetId": 1
},
"lineNbr": 11,
"author": {
"id": 13734
},
"writtenOn": "2016-04-22T13:25:45Z",
"side": 1,
"message": "Well the Plugin Guide is just calico-fuel-plugin-2.0. Don\u0027t you think it makes sense to have a nice way of seeing all of the docs that we have in this repository?",
"parentUuid": "1a122d0e_89997f22",
"range": {
"startLine": 10,
"startChar": 0,
"endLine": 11,
"endChar": 32
},
"revId": "d0b3c196bbd3f0b08df66ece24fba1b1f7ea3d57",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}