x
/
fuel-plugin-calico
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(19 comments)

Patch-set: 5
Label: Verified=0
This commit is contained in:
Gerrit User 7468 2016-09-15 11:42:32 +00:00 committed by Gerrit Code Review
parent 49cddbf19a
commit 8ccc956597
1 changed files with 342 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

342
2162f4a24a506d529ec575e106c3e8652d9ef832
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_55eec7ec",
"filename": "/COMMIT_MSG",
"patchSetId": 5
},
"lineNbr": 9,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Done",
"parentUuid": "9a89bdaa_41994e78",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a89bdaa_e128a2e4",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_351cdb11",
"filename": "README.md",
"patchSetId": 5
},
"lineNbr": 87,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Done",
"parentUuid": "9a89bdaa_e128a2e4",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9a89bdaa_7c799592",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_95e12fd3",
"filename": "components.yaml",
"patchSetId": 5
},
"lineNbr": 6,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Fuel has two default deployment methods: vlan and tun (gre or vxlan).\nIn the vlan UI proposed 802.1q IDs set configuration.\nIn the tun -- network for building tunnels. In the plugin we did not require tunnels, but we need a dedicated network to pass bgp and private traffic.",
"parentUuid": "9a89bdaa_7c799592",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_2a6f3fc6",
@ -68,6 +122,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_3595bbdd",
"filename": "deployment_scripts/puppet/manifests/compute_neutron_nova.pp",
"patchSetId": 5
},
"lineNbr": 9,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Any nova setups for neutron looks like brothers. But we (in the plugins) has two methods for customizing setup:\n1. re-configure something after ordinary deploy\n2. replace native fuel task for custom implementation.\nSecond way is more powerful, because ma be idempotent. 1st way never idempltent. Idempotency is very required while you operate cluster for re-deploy, upgrade, or add nodes.",
"parentUuid": "7a8ec9b2_2a6f3fc6",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_5f736f80",
@ -85,6 +157,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_f55fd33e",
"filename": "deployment_scripts/puppet/manifests/neutron_server_config.pp",
"patchSetId": 5
},
"lineNbr": 2,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "we should make plugin tasks more idempotency. It required while upgrades, mantenancy, node adding.",
"parentUuid": "7a8ec9b2_5f736f80",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_7f0f4b2e",
@ -102,6 +192,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_70759196",
"filename": "deployment_scripts/puppet/manifests/private_gateway_check.pp",
"patchSetId": 5
},
"lineNbr": 1,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Some misconfiguration will be checked here. Deployment process will be failed shortly close to deployment start. If used setup was wrong End user will be informed at 1st 2-3 min of deployment, instead 30-40.",
"parentUuid": "7a8ec9b2_7f0f4b2e",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_dceead8a",
@ -119,6 +227,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_f04c4144",
"filename": "deployment_scripts/puppet/modules/calico/Modulefile",
"patchSetId": 5
},
"lineNbr": 2,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Just a ::calico module, that carry with plugin and used into plugin manifests. It\u0027s not a calico-plugin version. Nothing important.",
"parentUuid": "7a8ec9b2_dceead8a",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_2dc5a43b",
@ -136,6 +262,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_50e255a0",
"filename": "deployment_scripts/puppet/modules/calico/manifests/params.pp",
"patchSetId": 5
},
"lineNbr": 1,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Done",
"parentUuid": "7a8ec9b2_2dc5a43b",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_0df6288f",
@ -153,6 +297,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_3078692a",
"filename": "deployment_scripts/puppet/modules/calico/manifests/params.pp",
"patchSetId": 5
},
"lineNbr": 18,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "O! my fault. This is unused parameters.",
"parentUuid": "7a8ec9b2_0df6288f",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_50b7e738",
@ -170,6 +332,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_d01025ab",
"filename": "deployment_scripts/puppet/modules/calico/manifests/params.pp",
"patchSetId": 5
},
"lineNbr": 27,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Too much unused variables was here, removed.",
"parentUuid": "7a8ec9b2_50b7e738",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_5c97fd8f",
@ -187,6 +367,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_304b09cb",
"filename": "deployment_scripts/puppet/modules/calico/manifests/params.pp",
"patchSetId": 5
},
"lineNbr": 37,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Done",
"parentUuid": "7a8ec9b2_5c97fd8f",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_1c42d510",
@ -204,6 +402,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_10f52d82",
"filename": "deployment_scripts/puppet/modules/calico/manifests/params.pp",
"patchSetId": 5
},
"lineNbr": 44,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Done",
"parentUuid": "7a8ec9b2_1c42d510",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_2da0449f",
@ -221,6 +437,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_d0166554",
"filename": "deployment_scripts/puppet/modules/calico/templates/bird-compute.conf.erb",
"patchSetId": 5
},
"lineNbr": 24,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "This interface is a endpoint of private network. This network is used for carry BGP and private (instance-to-instance, instance-to-world) traffic.",
"parentUuid": "7a8ec9b2_2da0449f",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_0d1e280c",
@ -238,6 +472,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_2b363ae6",
"filename": "deployment_scripts/puppet/modules/calico/templates/bird-peer-rr.conf.erb",
"patchSetId": 5
},
"lineNbr": 10,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "in simpliest cases -- yes. But if we will have more than one IP address per interface -- will be better to have ability for more strong definition. I have a plan (see todo in commit message) support existing bird configuration, provided by underlay.",
"parentUuid": "7a8ec9b2_0d1e280c",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_cd7360b0",
@ -255,6 +507,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_4b69c68a",
"filename": "deployment_scripts/puppet/modules/calico/templates/calico-alt-gateway.conf.erb",
"patchSetId": 5
},
"lineNbr": 2,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "It\u0027s a simple. \nCompute node has default routing through public (if public network assigned on all nodes) or management (in common cases). In this plugin implementation I separate BGP and private traffic to private network. I.e. for traffic from instances to outside world we should have alternative default gateway. I.e. source routing. This script creates alternative routing table and rules for pass marked traffic by alternative way.",
"parentUuid": "7a8ec9b2_cd7360b0",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_17f6398f",
@ -272,6 +542,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_0b1dfe0e",
"filename": "environment_config.yaml",
"patchSetId": 5
},
"lineNbr": 4,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Done",
"parentUuid": "7a8ec9b2_17f6398f",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_9a2b5082",
@ -289,6 +577,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_2bf39ad7",
"filename": "environment_config.yaml",
"patchSetId": 5
},
"lineNbr": 43,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "It is RESTRICTION. if condition True, field will be disabled.\n\nIPv6 not implemented now and temporary blocked.",
"parentUuid": "7a8ec9b2_9a2b5082",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_b7cae59f",
@ -306,6 +612,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_8bbe6ed2",
"filename": "node_roles.yaml",
"patchSetId": 5
},
"lineNbr": 18,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Done",
"parentUuid": "7a8ec9b2_b7cae59f",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_45abaa1d",
@ -322,6 +646,24 @@
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a8ec9b2_8bbaeebe",
"filename": "specs/calico-fuel-plugin.rst",
"patchSetId": 5
},
"lineNbr": 148,
"author": {
"id": 7468
},
"writtenOn": "2016-09-15T11:42:32Z",
"side": 1,
"message": "Done",
"parentUuid": "7a8ec9b2_45abaa1d",
"revId": "2162f4a24a506d529ec575e106c3e8652d9ef832",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}