x
/
fuel-plugin-calico
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(5 comments)

A few queries and possible markups here.

Patch-set: 1
Reviewer: Gerrit User 13734 <13734@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Workflow=0
This commit is contained in:
Gerrit User 13734 2016-01-11 15:40:16 +00:00 committed by Gerrit Code Review
parent 05b640ba56
commit 8f4f0fd92a
1 changed files with 89 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

89
8f0d8d149bc63d9cad7a83571efa603160697d90 Normal file
View File

@ -0,0 +1,89 @@
{
"comments": [
{
"key": {
"uuid": "fa69d971_871732ed",
"filename": "deployment_scripts/calico-fuel-monitor",
"patchSetId": 1
},
"lineNbr": 35,
"author": {
"id": 13734
},
"writtenOn": "2016-01-11T15:40:16Z",
"side": 1,
"message": "Seems more complex than needed. Why not just:\n\n for node in nodes:\n if node[\"role\"] \u003d\u003d \"primary-controller\":\n node[\"role\"] \u003d \"controller\"\n\nAlso think this needs a comment to explain why we doing this, and what effect the \u0027controller\u0027 change will have in the rest of the Fuel system.",
"revId": "8f0d8d149bc63d9cad7a83571efa603160697d90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_a74356ae",
"filename": "deployment_scripts/calico_compute.sh",
"patchSetId": 1
},
"lineNbr": 55,
"author": {
"id": 13734
},
"writtenOn": "2016-01-11T15:40:16Z",
"side": 1,
"message": "I\u0027d prefer \u0027do\u0027 on the next line, and no semicolon",
"revId": "8f0d8d149bc63d9cad7a83571efa603160697d90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_a74836b4",
"filename": "deployment_scripts/calico_controller.sh",
"patchSetId": 1
},
"lineNbr": 55,
"author": {
"id": 13734
},
"writtenOn": "2016-01-11T15:40:16Z",
"side": 1,
"message": "Same here.",
"revId": "8f0d8d149bc63d9cad7a83571efa603160697d90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_27b8c674",
"filename": "deployment_scripts/join_existing_cluster.sh",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 13734
},
"writtenOn": "2016-01-11T15:40:16Z",
"side": 1,
"message": "I don\u0027t think anything else in this change calls join_existing_cluster.sh. So is this actually used?",
"revId": "8f0d8d149bc63d9cad7a83571efa603160697d90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa69d971_2a7e4d6a",
"filename": "deployment_scripts/update_etcd_cluster.sh",
"patchSetId": 1
},
"lineNbr": 7,
"author": {
"id": 13734
},
"writtenOn": "2016-01-11T15:40:16Z",
"side": 1,
"message": "Same again here.",
"revId": "8f0d8d149bc63d9cad7a83571efa603160697d90",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}