x
/
fuel-plugin-detach-database
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(3 comments)

Patch-set: 1
Label: Verified=0
This commit is contained in:
Gerrit User 9387 2016-06-09 06:34:30 +00:00 committed by Gerrit Code Review
parent 26d0621b60
commit 177ee61e7a
1 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
af41423650028c0119bd24e67d0c481d2265330b
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_7d451141",
"filename": "deployment_tasks.yaml",
"patchSetId": 1
},
"lineNbr": 9,
"author": {
"id": 9387
},
"writtenOn": "2016-06-09T06:34:30Z",
"side": 1,
"message": "\u0027cluster\u0027 task is replaced by \u0027database-cluster\u0027. If we keep \u0027cluster\u0027 task here it will cause dependency like this with library patch:\n\n primary-controller/primary-cluster -\u003e *ALL_ROLES*/cluster\n\nand like this without library patch (current situation):\n\n *ALL_ROLES*/primary-cluster -\u003e *ALL_ROLES*/cluster\n\nWhich does not make much sense to me. So could you please clarify what you mean?",
"parentUuid": "7aa08908_cf529934",
"range": {
"startLine": 9,
"startChar": 53,
"endLine": 9,
"endChar": 54
},
"revId": "af41423650028c0119bd24e67d0c481d2265330b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_af28ed9a",
@ -69,6 +93,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_bda019f5",
"filename": "deployment_tasks.yaml",
"patchSetId": 1
},
"lineNbr": 77,
"author": {
"id": 9387
},
"writtenOn": "2016-06-09T06:34:30Z",
"side": 1,
"message": "Done",
"parentUuid": "7aa08908_0f1e616f",
"range": {
"startLine": 77,
"startChar": 17,
"endLine": 77,
"endChar": 27
},
"revId": "af41423650028c0119bd24e67d0c481d2265330b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_4f14e94b",
@ -91,6 +139,30 @@
"revId": "af41423650028c0119bd24e67d0c481d2265330b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7aa08908_1da4cd05",
"filename": "deployment_tasks.yaml",
"patchSetId": 1
},
"lineNbr": 91,
"author": {
"id": 9387
},
"writtenOn": "2016-06-09T06:34:30Z",
"side": 1,
"message": "Done",
"parentUuid": "7aa08908_4f14e94b",
"range": {
"startLine": 91,
"startChar": 17,
"endLine": 91,
"endChar": 27
},
"revId": "af41423650028c0119bd24e67d0c481d2265330b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}