Browse Source

Fix a cycle in graph of tasks

This patch removes a dependency that causes a cycle in the graph of
tasks in MOS 8. The cycle was <custom>-netconfig -> hosts -> cluster ->
virtual_ips -> <custom>-netconfig.

We cannot remove hosts.pp as we tried previously because doing this also
remove a dependency between globals and hosts. So we create the
following dependency: tools -> <custom>-netconfig -> hosts
in place of the former: tools -> netconfig -> hosts

Change-Id: I9a2ec06e3f61942ad33b9a32d9a6034602a51abd
Partial-Bug: #1616391
tags/1.0rc1
Guillaume Thouvenin 2 years ago
parent
commit
db94ccbc8c
1 changed files with 10 additions and 3 deletions
  1. 10
    3
      deployment_tasks.yaml

+ 10
- 3
deployment_tasks.yaml View File

@@ -85,12 +85,19 @@
85 85
   reexecute_on:
86 86
     - deploy_changes
87 87
 
88
-# We cannot use the legacy 'netconfig' task because it won't create the proper
89
-# dependency on the virtual management router task.
88
+# We cannot use the legacy 'netconfig' task because with MOS 9, it won't create
89
+# the proper dependency on the 'virtual_ips' task for the Elasticsearch-Kibana
90
+# nodes. As a consequence, the deployment will fail because the nodes will
91
+# perform operations that download stuff from the Internet (like running
92
+# 'apt-get update') while the virtual router isn't ready yet. For MOS 8, the
93
+# task depends on the 'tools' task and not on the 'virtual_ips' task otherwise
94
+# it creates a dependency cycle. In this case, this isn't an issue because the
95
+# default gateway is only changed at post-deployment (see the
96
+# 'influxdb-configure-default-route' task).
90 97
 - id: elasticsearch-netconfig
91 98
   type: puppet
92 99
   version: 2.0.0
93
-  requires: [elasticsearch-check-configuration, virtual_ips]
100
+  requires: [elasticsearch-check-configuration, tools]
94 101
   required_for: [deploy_end, hosts]
95 102
   cross-depends:
96 103
     - name: virtual_ips

Loading…
Cancel
Save