Add tox environment to test Puppet manifests

This change adds syntax checking and lint tests for the Puppet
manifests locates in deployment_scripts/puppet/manifests.

It also fixes a Puppet lint problem in base.pp as well as illegal key
assignments that aren't allowed with Puppet 4.x.

Change-Id: I3a6913773d3c3952e882db5644b8cc2289cee8fa

tox.ini

@@ -1,10 +1,23 @@
 [tox]
-envlist = heka,lma_collector,docs,build_plugin
+envlist = manifests,heka,lma_collector,docs,build_plugin
 skipsdist = True
 
 [testenv]
 deps = -r{toxinidir}/test-requirements.txt
 
+[testenv:manifests]
+deps =
+changedir = {toxinidir}/deployment_scripts/puppet/manifests
+whitelist_externals =
+    bundle
+    mkdir
+setenv =
+    GEM_HOME={toxinidir}/.bundled_gems
+commands =
+    mkdir -p {toxinidir}/.bundled_gems
+    bundle install
+    bundle exec rake test
+
 [testenv:heka]
 deps =
 changedir = {toxinidir}/deployment_scripts/puppet/modules/{envname}