x/gantt
Code Issues Proposed changes

update compute_fill_first_cost_fn docstring

Browse Source 
The default value for weight of the compute_fill_first_cost_fn is
actually -1.0, which means it does exactly the opposite of what
the function docstring says it does. Update the docstring to
warn people of this fact.

Issue reported via bug #1023827 which was closed as won't fix
but the docs should be clearer. Updated based on feedback.

Change-Id: I56acde254c932a8e66f941aaeb7304665500610f
This commit is contained in:
Sean Dague
2012-07-24 14:14:48 -04:00
parent 9a8605cfaa
commit 6e909ade6e
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
nova/scheduler/least_cost.py
View File

@@ -79,8 +79,13 @@ def noop_cost_fn(host_state, weighing_properties):
def compute_fill_first_cost_fn(host_state, weighing_properties): def compute_fill_first_cost_fn(host_state, weighing_properties):
"""More free ram = higher weight. So servers will less free """More free ram = higher weight. So servers with less free
ram will be preferred.""" ram will be preferred.
Note: the weight for this function in default configuration
is -1.0. With a -1.0 this function runs in reverse, so systems
with the most free memory will be preferred.
"""
return host_state.free_ram_mb return host_state.free_ram_mb