x/gantt
Code Issues Proposed changes

fix pylint W0102 errors.

Browse Source
This commit is contained in:
Matthew Hooker
2011-08-03 20:26:37 -04:00
parent e440b8a662
commit 759d7c0c4e
4 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nova/scheduler/manager.py
View File

@@ -69,8 +69,10 @@ class SchedulerManager(manager.Manager):
return self.zone_manager.get_zone_capabilities(context) return self.zone_manager.get_zone_capabilities(context)
def update_service_capabilities(self, context=None, service_name=None, def update_service_capabilities(self, context=None, service_name=None,
host=None, capabilities={}): host=None, capabilities=None):
"""Process a capability update from a service node.""" """Process a capability update from a service node."""
if not capability:
capability = {}
self.zone_manager.update_service_capabilities(service_name, self.zone_manager.update_service_capabilities(service_name,
host, capabilities) host, capabilities)

7
nova/tests/test_auth.py
View File

@@ -62,7 +62,12 @@ class project_generator(object):
class user_and_project_generator(object): class user_and_project_generator(object):
def __init__(self, manager, user_state={}, project_state={}): def __init__(self, manager, user_state=None, project_state=None):
if not user_state:
user_state = {}
if not project_state:
project_state = {}
self.manager = manager self.manager = manager
if 'name' not in user_state: if 'name' not in user_state:
user_state['name'] = 'test1' user_state['name'] = 'test1'

10
nova/tests/test_compute.py
View File

@@ -73,8 +73,11 @@ class ComputeTestCase(test.TestCase):
self.stubs.Set(nova.image.fake._FakeImageService, 'show', fake_show) self.stubs.Set(nova.image.fake._FakeImageService, 'show', fake_show)
def _create_instance(self, params={}): def _create_instance(self, params=None):
"""Create a test instance""" """Create a test instance"""
if not params:
params = {}
inst = {} inst = {}
inst['image_ref'] = 1 inst['image_ref'] = 1
inst['reservation_id'] = 'r-fakeres' inst['reservation_id'] = 'r-fakeres'
@@ -87,8 +90,11 @@ class ComputeTestCase(test.TestCase):
inst.update(params) inst.update(params)
return db.instance_create(self.context, inst)['id'] return db.instance_create(self.context, inst)['id']
def _create_instance_type(self, params={}): def _create_instance_type(self, params=None):
"""Create a test instance""" """Create a test instance"""
if not params:
params = {}
context = self.context.elevated() context = self.context.elevated()
inst = {} inst = {}
inst['name'] = 'm1.small' inst['name'] = 'm1.small'

5
nova/tests/test_libvirt.py
View File

@@ -1162,8 +1162,11 @@ class NWFilterTestCase(test.TestCase):
'project_id': 'fake', 'project_id': 'fake',
'instance_type_id': 1}) 'instance_type_id': 1})
def _create_instance_type(self, params={}): def _create_instance_type(self, params=None):
"""Create a test instance""" """Create a test instance"""
if not params:
params = {}
context = self.context.elevated() context = self.context.elevated()
inst = {} inst = {}
inst['name'] = 'm1.small' inst['name'] = 'm1.small'