x/gearman-plugin
Code Issues Proposed changes

Use AbstractProject instead of Project in function factory.

Browse Source 
Fixes an illegal argument exception.

Change-Id: I9a1fde359e043b7cdf2fb1e635ac65a6196dc0c0
This commit is contained in:
James E. Blair 2013-06-14 16:06:14 -07:00
parent eb27ce4c23
commit 474afb007b
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/main/java/hudson/plugins/gearman/CustomGearmanFunctionFactory.java
View File

@ -73,7 +73,7 @@ public class CustomGearmanFunctionFactory extends DefaultGearmanFunctionFactory
try { try {
Class<?> c = Class.forName(className); Class<?> c = Class.forName(className);
Constructor<?> con = c.getConstructor(new Class[]{Project.class, Node.class, String.class, MyGearmanWorkerImpl.class}); Constructor<?> con = c.getConstructor(new Class[]{AbstractProject.class, Node.class, String.class, MyGearmanWorkerImpl.class});
Object o = con.newInstance(new Object[] {project, node, masterName, worker}); Object o = con.newInstance(new Object[] {project, node, masterName, worker});
if (o instanceof GearmanFunction) { if (o instanceof GearmanFunction) {

4
src/main/java/hudson/plugins/gearman/StartJobWorker.java
View File

@ -70,11 +70,11 @@ public class StartJobWorker extends AbstractGearmanFunction {
.getLogger(Constants.PLUGIN_LOGGER_NAME); .getLogger(Constants.PLUGIN_LOGGER_NAME);
Node node; Node node;
Project<?, ?> project; AbstractProject<?, ?> project;
String masterName; String masterName;
MyGearmanWorkerImpl worker; MyGearmanWorkerImpl worker;
public StartJobWorker(Project<?, ?> project, Node node, String masterName, public StartJobWorker(AbstractProject<?, ?> project, Node node, String masterName,
MyGearmanWorkerImpl worker) { MyGearmanWorkerImpl worker) {
this.project = project; this.project = project;
this.node = node; this.node = node;