Update patch set 1
Patch Set 1: Code-Review-1 (3 comments) Patch-set: 1 Label: Code-Review=-1
This commit is contained in:
parent
e5d03cc092
commit
9a3cd2256a
@ -34,6 +34,40 @@
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3acd31a7_96b44f82",
|
||||
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 256,
|
||||
"author": {
|
||||
"id": 1
|
||||
},
|
||||
"writtenOn": "2015-05-05T14:23:24Z",
|
||||
"side": 1,
|
||||
"message": "The \"if we\u0027re sleeping\" in the comment is important. This will have no effect if we have not already sent a PRE_SLEEP packet. Note that is generally a good thing because if we send more than one GRAB_JOB, gearman will happily send us more than one JOB_ASSIGN which we can not handle. However, because of the suppression, this can not be used to send the initial GRAB_JOB. More below.",
|
||||
"revId": "4f2f53f38a857e6cae0061cb885270b41e44e7ca",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3acd31a7_76b9b378",
|
||||
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 301,
|
||||
"author": {
|
||||
"id": 1
|
||||
},
|
||||
"writtenOn": "2015-05-05T14:23:24Z",
|
||||
"side": 1,
|
||||
"message": "I expect we will get stuck here immediately at startup because we send no initial packet.",
|
||||
"revId": "4f2f53f38a857e6cae0061cb885270b41e44e7ca",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3acd31a7_a0aee57e",
|
||||
|
21
6de3cdd29bb8c4336a468985af6f8e0e4fd88e66
Normal file
21
6de3cdd29bb8c4336a468985af6f8e0e4fd88e66
Normal file
@ -0,0 +1,21 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "3acd31a7_56b35798",
|
||||
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 306,
|
||||
"author": {
|
||||
"id": 1
|
||||
},
|
||||
"writtenOn": "2015-05-05T14:23:24Z",
|
||||
"side": 0,
|
||||
"message": "This code sends the initial GRAB_JOB packet that kicks off the state machine. This change omits this code, relying on enqueing a fake NOOP instead, but that won\u0027t work because we won\u0027t have sent a PRE_SLEEP before. I think something like this strategy is required, along with the other cases where sendGrabJob is reset (to make sure we always send the initial packet on reconnect.)",
|
||||
"revId": "6de3cdd29bb8c4336a468985af6f8e0e4fd88e66",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user