x/gearman-plugin
Code Issues Proposed changes

Update patch set 2

Browse Source 
Patch Set 2: Code-Review-1

(1 comment)

Still don't fully understand this yet, but did catch a problem i wanted to let you know about.

Patch-set: 2
Reviewer: Gerrit User 6987 <6987@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 6987 2015-05-01 23:28:07 +00:00 committed by Gerrit Code Review
parent 33ddeb4060
commit e138300fa4
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
dc60cad76904c7b95d2153e1f0e9ca88a5e1b478 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "3acd31a7_ebb64089",
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
"patchSetId": 2
},
"lineNbr": 370,
"author": {
"id": 6987
},
"writtenOn": "2015-05-01T23:28:07Z",
"side": 1,
"message": "When I send a job to the server the taskMap is empty at this point which will set currentTask to null. I believe the session.driveSessionIO() just above may cause a session event and make the handleSessionEvent to empty out the taskMap. I think calling this before driveSessionIO may work.",
"revId": "dc60cad76904c7b95d2153e1f0e9ca88a5e1b478",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}