56 lines
2.5 KiB
Plaintext
56 lines
2.5 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3a50d1a3_1d7fc1e0",
|
|
"filename": "src/main/java/hudson/plugins/gearman/StartJobWorker.java",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 92,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2015-07-23T15:14:26Z",
|
|
"side": 1,
|
|
"message": "Many of our jobs are configured to be built on more than one label (eg \"devstack-precise || devstack-trusty\"). What happens in this case?\n\nAnd of course, while all of our jobs are configured to run on at least one label, it\u0027s certainly possible for zuul to work with a system where jobs are not tied to labels at all. This will return null in that case, I believe.",
|
|
"revId": "f7bbb0f218f53b8c41e03b844007f063eb86d332",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3a50d1a3_8344d249",
|
|
"filename": "src/main/java/hudson/plugins/gearman/StartJobWorker.java",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 92,
|
|
"author": {
|
|
"id": 6987
|
|
},
|
|
"writtenOn": "2015-07-23T15:35:33Z",
|
|
"side": 1,
|
|
"message": "The AbstractBuild object has a method that will tell you the slave that the job was run on. So instead of getting the label maybe add \u0027builtOn\u0027 info? Also this may require some additional processing in zuul since our slaves have names like \"devstack-trusty-rax-dfw-3909105\". \n\nhere is the api:\nhttp://javadoc.jenkins-ci.org/hudson/model/AbstractBuild.html#getBuiltOn()",
|
|
"revId": "f7bbb0f218f53b8c41e03b844007f063eb86d332",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3a50d1a3_576bddb6",
|
|
"filename": "src/main/java/hudson/plugins/gearman/StartJobWorker.java",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 92,
|
|
"author": {
|
|
"id": 11610
|
|
},
|
|
"writtenOn": "2015-08-11T19:15:52Z",
|
|
"side": 1,
|
|
"message": "Hi Khai, I\u0027d like to avoid trying to do an parsing or inferring node types from hostnames if possible. I think I came up with a solution which will let me identify and store the specific node label that triggered the job on that worker and send it back to zuul in the status packet. Let me know what you think.",
|
|
"parentUuid": "3a50d1a3_8344d249",
|
|
"revId": "f7bbb0f218f53b8c41e03b844007f063eb86d332",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |