89 lines
2.9 KiB
Plaintext
89 lines
2.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3acd31a7_a0f14503",
|
|
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 40,
|
|
"author": {
|
|
"id": 7069
|
|
},
|
|
"writtenOn": "2015-05-05T13:23:36Z",
|
|
"side": 1,
|
|
"message": "(nit) I believe this was meant to be alphabetical",
|
|
"revId": "4f2f53f38a857e6cae0061cb885270b41e44e7ca",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3acd31a7_00ffd9aa",
|
|
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 256,
|
|
"author": {
|
|
"id": 7069
|
|
},
|
|
"writtenOn": "2015-05-05T13:23:36Z",
|
|
"side": 1,
|
|
"message": "(nit) missing period at end of cycle.",
|
|
"revId": "4f2f53f38a857e6cae0061cb885270b41e44e7ca",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3acd31a7_96b44f82",
|
|
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 256,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2015-05-05T14:23:24Z",
|
|
"side": 1,
|
|
"message": "The \"if we\u0027re sleeping\" in the comment is important. This will have no effect if we have not already sent a PRE_SLEEP packet. Note that is generally a good thing because if we send more than one GRAB_JOB, gearman will happily send us more than one JOB_ASSIGN which we can not handle. However, because of the suppression, this can not be used to send the initial GRAB_JOB. More below.",
|
|
"revId": "4f2f53f38a857e6cae0061cb885270b41e44e7ca",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3acd31a7_76b9b378",
|
|
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 301,
|
|
"author": {
|
|
"id": 1
|
|
},
|
|
"writtenOn": "2015-05-05T14:23:24Z",
|
|
"side": 1,
|
|
"message": "I expect we will get stuck here immediately at startup because we send no initial packet.",
|
|
"revId": "4f2f53f38a857e6cae0061cb885270b41e44e7ca",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3acd31a7_a0aee57e",
|
|
"filename": "src/main/java/hudson/plugins/gearman/MyGearmanWorkerImpl.java",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 306,
|
|
"author": {
|
|
"id": 7069
|
|
},
|
|
"writtenOn": "2015-05-05T13:23:36Z",
|
|
"side": 1,
|
|
"message": "(nit) Spaces after //",
|
|
"revId": "4f2f53f38a857e6cae0061cb885270b41e44e7ca",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |