From 1eb606ae9dcddca749f18e063d6bbce34188c726 Mon Sep 17 00:00:00 2001 From: Michal Nasiadka Date: Thu, 28 Oct 2021 13:37:48 +0200 Subject: [PATCH] Unify Kolla projects dashboard Change-Id: I83fbdb72dca815a6d6da4ade9bf7a60bf12d5cdd --- dashboards/kayobe.dash | 29 +++++++++++++---------------- dashboards/kolla-ansible.dash | 22 +++++++++++----------- dashboards/kolla.dash | 22 +++++++++++----------- 3 files changed, 35 insertions(+), 38 deletions(-) diff --git a/dashboards/kayobe.dash b/dashboards/kayobe.dash index d5eca4d..67c0bf7 100644 --- a/dashboards/kayobe.dash +++ b/dashboards/kayobe.dash @@ -1,10 +1,7 @@ [dashboard] title = Kayobe Review Dashboard description = Summary of Kayobe Patches to Review -foreach = (project:openstack/kayobe OR project:openstack/kayobe-config OR project:openstack/kayobe-config-dev) status:open NOT label:Code-Review<=-2 - -[section "My Patches Requiring Attention"] -query = owner:self (label:Verified-1,zuul OR label:Code-Review-1 OR label:Workflow<=-1) +foreach = (project:openstack/kayobe OR project:openstack/kayobe-config OR project:openstack/kayobe-config-dev) status:open NOT label:Code-Review<=-2 NOT label:Workflow<=-1 [section "High priority changes"] query = label:Review-Priority=2 @@ -15,20 +12,20 @@ query = label:Review-Priority=1 [section "Feature freeze"] query = label:Review-Priority=-1 -[section "Small things (<25 LOC, limit 10)"] -query = delta:<=25 limit:10 (NOT label:Code-Review-1,kayobe-core) label:Verified>=1,zuul branch:master +[section "Stable branch backports"] +query = branch:^stable/.* status:open NOT label:Review-Priority=-1 -[section "Needs Reverify"] -query = label:Workflow>=1 NOT label:Workflow<=-1 label:Verified<=-1,zuul +[section "Small things (<25 LOC, limit 25) on master branch"] +query = delta:<=25 limit:25 NOT label:Code-Review-1 label:Verified>=1,zuul NOT label:Review-Priority=-1 branch:master -[section "Needs Final Approval (to land on master)"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT owner:self label:Code-Review>=2 label:Verified>=1,zuul (NOT label:Code-Review-1,kayobe-core) branch:master +[section "Needs Final Approval (to land on master branch)"] +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT owner:self label:Code-Review>=2 label:Verified>=1,zuul NOT label:Review-Priority=-1 branch:master -[section "Newer (<1wk) Open Patches (limit 25)"] -query = -age:1week limit:25 branch:master NOT label:Workflow>=1 (NOT label:Code-Review-1,kayobe-core) label:Verified>=1,zuul NOT label:Code-Review>=2 +[section "Needs revisit (You were a reviewer but haven't voted in the current revision)"] +query = reviewer:self limit:50 -[section "Older (>1wk) Open Patches Passing Zuul Tests (limit 50)"] -query = age:1week limit:50 NOT label:Workflow>=1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 label:Verified>=1,zuul (NOT label:Code-Review-1,kayobe-core) +[section "Newer (<1wk) Open Patches (limit 25) on master branch"] +query = -age:1week limit:25 NOT label:Workflow>=1 label:Verified>=1,zuul NOT label:Code-Review>=2 NOT label:Review-Priority=-1 branch:master -[section "Open Stable Backports"] -query = branch:^stable/.* status:open +[section "Older (>1wk) Open Patches Passing Zuul Tests (limit 50) on master branch"] +query = age:1week limit:50 NOT label:Workflow>=1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 label:Verified>=1,zuul NOT label:Review-Priority=-1 branch:master diff --git a/dashboards/kolla-ansible.dash b/dashboards/kolla-ansible.dash index 2f26612..1e5c4ef 100644 --- a/dashboards/kolla-ansible.dash +++ b/dashboards/kolla-ansible.dash @@ -3,9 +3,6 @@ title = Kolla-Ansible Review Dashboard description = Summary of Kolla-Ansible patches to review foreach = project:openstack/kolla-ansible status:open NOT label:Workflow<=-1 NOT label:Code-Review<=-2 -[section "My Patches Requiring Attention"] -query = owner:self (label:Verified-1,zuul OR label:Code-Review-1 OR label:Workflow<=-1) - [section "High priority changes"] query = label:Review-Priority=2 @@ -18,14 +15,17 @@ query = label:Review-Priority=-1 [section "Stable branch backports"] query = branch:^stable/.* status:open NOT label:Review-Priority=-1 -[section "Needs Reverify"] -query = label:Workflow>=1 NOT label:Workflow<=-1 label:Verified<=-1,zuul NOT label:Review-Priority=-1 +[section "Small things (<25 LOC, limit 25) on master branch"] +query = delta:<=25 limit:25 NOT label:Code-Review-1 label:Verified>=1,zuul NOT label:Review-Priority=-1 branch:master -[section "Needs Final Approval (to land on master)"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT owner:self label:Code-Review>=2 label:Verified>=1,zuul branch:master NOT label:Review-Priority=-1 +[section "Needs Final Approval (to land on master branch)"] +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT owner:self label:Code-Review>=2 label:Verified>=1,zuul NOT label:Review-Priority=-1 branch:master -[section "Newer (<1wk) Open Patches (limit 100)"] -query = -age:1week limit:100 branch:master NOT label:Workflow>=1 label:Verified>=1,zuul NOT label:Code-Review>=2 NOT label:Review-Priority=-1 +[section "Needs revisit (You were a reviewer but haven't voted in the current revision)"] +query = reviewer:self limit:50 -[section "Older (>1wk) Open Patches Passing Zuul Tests (limit 50)"] -query = age:1week limit:50 NOT label:Workflow>=1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 label:Verified>=1,zuul NOT label:Review-Priority=-1 +[section "Newer (<1wk) Open Patches (limit 25) on master branch"] +query = -age:1week limit:25 NOT label:Workflow>=1 label:Verified>=1,zuul NOT label:Code-Review>=2 NOT label:Review-Priority=-1 branch:master + +[section "Older (>1wk) Open Patches Passing Zuul Tests (limit 50) on master branch"] +query = age:1week limit:50 NOT label:Workflow>=1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 label:Verified>=1,zuul NOT label:Review-Priority=-1 branch:master diff --git a/dashboards/kolla.dash b/dashboards/kolla.dash index 0313347..b2c538f 100644 --- a/dashboards/kolla.dash +++ b/dashboards/kolla.dash @@ -3,9 +3,6 @@ title = Kolla Review Dashboard description = Summary of Kolla patches to review foreach = project:openstack/kolla status:open NOT label:Workflow<=-1 NOT label:Code-Review<=-2 -[section "My Patches Requiring Attention"] -query = owner:self (label:Verified-1,zuul OR label:Code-Review-1 OR label:Workflow<=-1) - [section "High priority changes"] query = label:Review-Priority=2 @@ -18,14 +15,17 @@ query = label:Review-Priority=-1 [section "Stable branch backports"] query = branch:^stable/.* status:open NOT label:Review-Priority=-1 -[section "Needs Reverify"] -query = label:Workflow>=1 NOT label:Workflow<=-1 label:Verified<=-1,zuul NOT label:Review-Priority=-1 +[section "Small things (<25 LOC, limit 25) on master branch"] +query = delta:<=25 limit:25 NOT label:Code-Review-1 label:Verified>=1,zuul NOT label:Review-Priority=-1 branch:master -[section "Needs Final Approval (to land on master)"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT owner:self label:Code-Review>=2 label:Verified>=1,zuul branch:master NOT label:Review-Priority=-1 +[section "Needs Final Approval (to land on master branch)"] +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT owner:self label:Code-Review>=2 label:Verified>=1,zuul NOT label:Review-Priority=-1 branch:master -[section "Newer (<1wk) Open Patches (limit 100)"] -query = -age:1week limit:100 branch:master NOT label:Workflow>=1 label:Verified>=1,zuul NOT label:Code-Review>=2 NOT label:Review-Priority=-1 +[section "Needs revisit (You were a reviewer but haven't voted in the current revision)"] +query = reviewer:self limit:50 -[section "Older (>1wk) Open Patches Passing Zuul Tests (limit 50)"] -query = age:1week limit:100 NOT label:Workflow>=1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 label:Verified>=1,zuul NOT label:Review-Priority=-1 +[section "Newer (<1wk) Open Patches (limit 25) on master branch"] +query = -age:1week limit:25 NOT label:Workflow>=1 label:Verified>=1,zuul NOT label:Code-Review>=2 NOT label:Review-Priority=-1 branch:master + +[section "Older (>1wk) Open Patches Passing Zuul Tests (limit 50) on master branch"] +query = age:1week limit:50 NOT label:Workflow>=1 NOT label:Code-Review<=-1 NOT label:Code-Review>=1 label:Verified>=1,zuul NOT label:Review-Priority=-1 branch:master