x
/
gerrit-dash-creator
Code Issues Proposed changes

Remove entries from need final +2 that have a -1 

A -1 on a commit means that more discussion needs to happen and it's
not ready for merge. However, the dashboard view for needs final +2
wasn't checking this. The perfect example was tempest change
I7c3cf17bfd8d273823774cd162ae011161c36d3d
which I feel shouldn't be in that list. This commit fixes this by
excluding any commit that has a -1 or -2.

Change-Id: I0a3cb2de5d598a707505f67ccb3b408f80d77784
This commit is contained in:
Matthew Treinish 2014-06-14 13:02:01 -04:00
parent 6d73df8643
commit 25b5067bc7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dashboards/qa-program.dash
View File

@ -13,7 +13,7 @@ query = NOT label:Code-Review<=2 age:5d
query = reviewer:self
[section "Needs final +2"]
query = (project:openstack/tempest OR project:openstack-dev/grenade) label:Code-Review>=2 limit:50
query = (project:openstack/tempest OR project:openstack-dev/grenade) label:Code-Review>=2 limit:50 NOT label:Code-Review<=-1
[section "Passed Jenkins, No Negative Feedback"]
query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50