x
/
gerrit-dash-creator
Code Issues Proposed changes

Fixed reviewedby:self logic 

""You are a reviewer, but haven't voted in the current revision" section
was showing patches that already had votes from self. Using
reviewedby:self doesn't help either because it matches against patches
that you voted for but someone important (like the author) happened to
comment after your vote. Hence the usage of Code-Review matching rule.

This was noticed for neutron dashboard but I fixed it in a bunch of
other places.

Change-Id: I0bd2a646df1e8f268472efcd740a9d3d51aea962
This commit is contained in:
Ihar Hrachyshka 2017-09-22 12:55:05 -07:00
parent 2487dcec99
commit 96142e865b
23 changed files with 26 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
dashboards/all-the-specs.dash
View File

@ -4,7 +4,7 @@ description = Review Inbox
foreach = project:^openstack/.*-specs status:open NOT owner:self NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT reviewedby:self branch:master
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Passed Jenkins, No Negative Feedback"]
query = NOT label:Code-Review<=-1 limit:100

2
dashboards/api-docs-impact.dash
View File

@ -14,4 +14,4 @@ query = (project:openstack/api-site) status:open
query = (project:openstack/*) (status:open) AND (message:ApiImpact OR message:APIImpact)
[section "You are a reviewer (but haven't voted in the current revision)"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self

2
dashboards/compute-program.dash
View File

@ -13,7 +13,7 @@ query = NOT label:Code-Review<=-1,nova-core delta:<=10
query = NOT label:Code-Review<=-1 NOT label:Code-Review>=1 NOT is:reviewed age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Bug fix, Passed Jenkins, No Negative Core Feedback"]
query = NOT label:Code-Review<=-1,nova-core message:"Closes-Bug: "

2
dashboards/designate.dash
View File

@ -11,7 +11,7 @@ query = branch:stable/mitaka NOT reviewedby:self
query = branch:stable/liberty NOT reviewedby:self
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self label:Verified>=1,jenkins NOT reviewedby:self NOT owner:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self label:Verified>=1,jenkins NOT owner:self
[section "Needs final +2"]
query = label:Code-Review>=2 label:Verified>=1,jenkins limit:50 NOT label:Workflow<=-1 NOT label:Workflow>=1 NOT label:Code-Review>=2,self NOT owner:self

2
dashboards/gate-changes.dash
View File

@ -7,7 +7,7 @@ foreach = (project:openstack-infra/project-config OR project:openstack-infra/dev
query = NOT label:Code-Review<=2 age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = label:Code-Review>=2 limit:50

2
dashboards/horizon-related-repos.dash
View File

@ -10,7 +10,7 @@ query = owner:self
query = is:starred
[section "Your are a reviewer, but haven't voted in the current revision"]
query = reviewer:self NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT reviewedby:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self NOT label:Workflow<=-1 label:Verified>=1,jenkins
[section "Needs Approval"]
query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 NOT label:Code-Review<=2,self

2
dashboards/horizon-stable.dash
View File

@ -8,7 +8,7 @@ foreach = (project:openstack/horizon OR
query = NOT label:Code-Review<=2 age:5d
[section "Your are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = label:Code-Review>=2 NOT(reviewerin:horizon-core label:Code-Review<=-1) limit:50

2
dashboards/horizon.dash
View File

@ -11,7 +11,7 @@ query = owner:self
query = is:starred
[section "Your are a reviewer, but haven't voted in the current revision"]
query = reviewer:self NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT reviewedby:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self NOT label:Workflow<=-1 label:Verified>=1,jenkins
[section "Needs Approval"]
query = NOT label:Workflow>=1 NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 NOT label:Code-Review<=2,self

2
dashboards/networking-midonet.dash
View File

@ -7,7 +7,7 @@ foreach = (project:openstack/networking-midonet) status:open NOT owner:self NOT
query = NOT label:Code-Review<=2 age:5d branch:master
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self branch:master
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self branch:master
[section "Needs final +2"]
query = label:Code-Review>=2 NOT(reviewerin:networking-midonet-core label:Code-Review<=-1) limit:50 branch:master

2
dashboards/neutron-subprojects-stable.dash
View File

@ -19,7 +19,7 @@ foreach = (
query = NOT label:Code-Review<=2 age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = label:Code-Review>=2 NOT(reviewerin:neutron-stable-maint label:Code-Review<=-1) limit:50

2
dashboards/neutron-subprojects.dash
View File

@ -16,7 +16,7 @@ foreach = (
query = NOT label:Code-Review<=2 age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = label:Code-Review>=2 NOT(reviewerin:neutron-core label:Code-Review<=-1) limit:50

2
dashboards/neutron.dash
View File

@ -11,7 +11,7 @@ foreach = (project:openstack/neutron OR
query = NOT label:Code-Review<=2 age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = label:Code-Review>=2 NOT(reviewerin:neutron-core label:Code-Review<=-1) limit:50

2
dashboards/nova-api.dash
View File

@ -16,7 +16,7 @@ query = project:openstack/nova-specs NOT reviewedby:self
query = NOT label:Code-Review<=2 age:5d
[section "Your are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = label:Code-Review>=2

6
dashboards/nova-specs.dash
View File

@ -4,16 +4,16 @@ description = Review Inbox
foreach = project:openstack/nova-specs status:open NOT label:Workflow<=-1 branch:master NOT owner:self
[section "You are a reviewer, but haven't voted in the current revision"]
query = file:^specs/queens/.* reviewer:self NOT reviewedby:self label:Verified>=1,jenkins
query = file:^specs/queens/.* NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self label:Verified>=1,jenkins
[section "Not blocked by -2s"]
query = file:^specs/queens/.* NOT label:Code-Review<=-2 NOT label:Code-Review>=2 NOT reviewedby:self label:Verified>=1,jenkins
query = file:^specs/queens/.* NOT label:Code-Review<=-2 NOT label:Code-Review>=2 NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self label:Verified>=1,jenkins
[section "No votes and spec is > 1 week old"]
query = file:^specs/queens/.* NOT label:Code-Review>=-2 age:7d label:Verified>=1,jenkins
[section "Needs final +2"]
query = file:^specs/queens/.* label:Code-Review>=2 NOT reviewedby:self label:Verified>=1,jenkins
query = file:^specs/queens/.* label:Code-Review>=2 NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self label:Verified>=1,jenkins
[section "Broken Specs (doesn't pass Jenkins)"]
query = file:^specs/queens/.* label:Verified<=-1,jenkins

2
dashboards/octavia.dash
View File

@ -10,7 +10,7 @@ foreach = (project:openstack/octavia OR
query = label:Verified>=1,jenkins label:Code-Review>=2 NOT(reviewerin:octavia-core label:Code-Review<=-1 OR label:Workflow>=1) limit:50
[section "You are a reviewer, but haven't voted in the current revision"]
query = label:Verified>=1,jenkins reviewer:self NOT label:Workflow<=-1 label:Verified>=1,jenkins NOT reviewedby:self limit:50
query = label:Verified>=1,jenkins NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self NOT label:Workflow<=-1 label:Verified>=1,jenkins limit:50
[section "Needs Feedback (Changes older than 5 days that have not been reviewed by anyone)"]
query = label:Verified>=1,jenkins NOT label:Code-Review<=2 age:5d limit:10

2
dashboards/openstackclient.dash
View File

@ -9,7 +9,7 @@ foreach = (project:openstack/python-openstackclient OR project:openstack/cliff)
query = NOT label:Code-Review<=2 age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = NOT label:Code-Review<=-2 label:Code-Review>=2

2
dashboards/qa-program.dash
View File

@ -16,7 +16,7 @@ query = NOT label:Code-Review<=-1,tempest-core delta:<=10
query = NOT label:Code-Review<=2 age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Bug fix, Passed Jenkins, No Negative Core Feedback"]
query = NOT label:Code-Review<=-1,tempest-core message:"Closes-Bug: "

4
dashboards/requirements.dash
View File

@ -10,7 +10,7 @@ query = topic:new-release
query = NOT label:Code-Review<=2 age:5d branch:master
[section "You are a reviewer, but haven't voted in the current revision"]
query = NOT reviewedby:self reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = label:Code-Review>=2 limit:50 NOT reviewedby:self
@ -22,4 +22,4 @@ query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50 branch:maste
query = NOT label:Code-Review<=2 age:2d branch:master
[section "Stable Branch Changes"]
query = branch:^stable/.*
query = branch:^stable/.*

2
dashboards/stable.dash
View File

@ -7,7 +7,7 @@ foreach = (project:openstack/ceilometer OR project:openstack/python-ceilometercl
query = NOT label:Code-Review<=2 age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = label:Code-Review>=2 NOT(reviewerin:stable-maint-core label:Code-Review<=-1) limit:50

2
dashboards/tap-as-a-service.dash
View File

@ -7,7 +7,7 @@ foreach = (project:openstack/tap-as-a-service OR project:openstack/tap-as-a-serv
query = NOT label:Code-Review<=2 age:5d branch:master
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self branch:master
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self branch:master
[section "Needs final +2"]
query = label:Code-Review>=2 NOT(reviewerin:tap-as-a-service-core label:Code-Review<=-1) limit:50 branch:master

2
dashboards/tempest.dash
View File

@ -10,7 +10,7 @@ query = project:openstack/qa-specs
query = NOT label:Code-Review<=2 age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = (project:openstack/tempest OR project:openstack-dev/grenade) label:Code-Review>=2 limit:50 NOT label:Code-Review<=-1

2
dashboards/tooz_taskflow.dash
View File

@ -7,7 +7,7 @@ foreach = (project:openstack/taskflow OR project:openstack/tooz) status:open NOT
query = NOT label:Code-Review<=2 age:5d
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Needs final +2"]
query = NOT label:Code-Review<=-2 label:Code-Review>=2

2
dashboards/watched.dash
View File

@ -4,7 +4,7 @@ description = Watched Projects
foreach = is:watched is:open
[section "You are a reviewer, but haven't voted in the current revision"]
query = reviewer:self
query = NOT label:Code-Review<=-1,self NOT label:Code-Review>=1,self reviewer:self
[section "Passed Jenkins, No Negative Feedback"]
query = NOT label:Code-Review>=2 NOT label:Code-Review<=-1 limit:50