From edba488158c60423d3189d1be815b3d32ffa3f67 Mon Sep 17 00:00:00 2001 From: Dmitry Borodaenko Date: Wed, 12 Aug 2015 17:36:12 -0700 Subject: [PATCH] Core Reviewer and Disagreement sections for Fuel Ready for Core Reviewers: there are +1, no -1, no -2, no +2 code reviews, and +1 from CI. Disagreement: there are positive and negative code reviews. Negative Feedback: there are -1, no -2, no +1 code reviews. Change-Id: Ife477107d3ac5f08be204149af4d16d829bdc171 --- dashboards/fuel.dash | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/dashboards/fuel.dash b/dashboards/fuel.dash index 19a2e25..a30e97c 100644 --- a/dashboards/fuel.dash +++ b/dashboards/fuel.dash @@ -10,13 +10,19 @@ query = owner:self (label:Verified-1 OR label:Code-Review-1 OR label:Workflow<=- query = NOT label:Workflow>=1 NOT owner:self project:stackforge/fuel-specs [section "Needs Approval"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self label:Code-Review>=2 NOT label:Code-Review-1 +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self label:Code-Review>=2 NOT label:Code-Review<=-1 + +[section "Ready for Core Reviewers"] +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:stackforge/fuel-specs label:Verified>=1 label:Code-Review>=1 NOT label:Code-Review>=2 NOT label:Code-Review<=-1 [section "5 Days Without Feedback"] query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:stackforge/fuel-specs NOT label:Code-Review<=2 age:5d -[section "No Negative Feedback"] -query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:stackforge/fuel-specs NOT label:Code-Review<=-1 NOT label:Code-Review>=2 limit:50 +[section "No Feedback"] +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:stackforge/fuel-specs NOT label:Code-Review<=2 NOT age:5d limit:50 -[section "Other"] -query = NOT label:Verified<=-1 NOT owner:self NOT project:stackforge/fuel-specs label:Code-Review-1 limit:20 +[section "Disagreement"] +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:stackforge/fuel-specs label:Code-Review<=-1 label:Code-Review>=1 + +[section "Negative Feedback"] +query = NOT label:Workflow>=1 NOT label:Workflow<=-1 NOT label:Verified<=-1 NOT owner:self NOT project:stackforge/fuel-specs label:Code-Review-1 NOT label:Code-Review<=-2 NOT label:Code-Review>=1 limit:20