diff --git a/bdd3f846520b836f6fd8c37cfe31d1d52ee37ec5 b/bdd3f846520b836f6fd8c37cfe31d1d52ee37ec5 index b90f3f7..a676e0f 100644 --- a/bdd3f846520b836f6fd8c37cfe31d1d52ee37ec5 +++ b/bdd3f846520b836f6fd8c37cfe31d1d52ee37ec5 @@ -191,6 +191,24 @@ "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "unresolved": false }, + { + "key": { + "uuid": "7aa08908_e06c7c0a", + "filename": "giftwrap/builders/__init__.py", + "patchSetId": 1 + }, + "lineNbr": 69, + "author": { + "id": 6488 + }, + "writtenOn": "2016-06-10T00:33:41Z", + "side": 1, + "message": "Sorry, python3 porting has broken my words here. Yes, the final product is an str object, which is a string of bytes in python2. In python 3, response.text is a str, which is a unicode, and encode returns a bytes:\n\nPython 3.5.1+ (default, Mar 30 2016, 22:46:26) \n[GCC 5.3.1 20160330] on linux\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n\u003e\u003e\u003e x \u003d u\"abc\"\n\u003e\u003e\u003e x.encode(\u0027utf-8\u0027)\nb\u0027abc\u0027\n\u003e\u003e\u003e x\n\u0027abc\u0027\n\u003e\u003e\u003e type(x)\n\u003cclass \u0027str\u0027\u003e\n\u003e\u003e\u003e \n\nThe code above works the right way in both.", + "parentUuid": "7aa08908_a0a0b4a6", + "revId": "bdd3f846520b836f6fd8c37cfe31d1d52ee37ec5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", + "unresolved": false + }, { "key": { "uuid": "7aa08908_4f45c615",