From 87509297f7f0079bef38eab7e103b7c1b7ad5e92 Mon Sep 17 00:00:00 2001 From: Craig Tracey Date: Mon, 17 Nov 2014 18:41:24 -0500 Subject: [PATCH] docker_builder updating template incorrectly dict.update updates a dict in place...fix the code to update the dict properly. --- giftwrap/builders/docker_builder.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/giftwrap/builders/docker_builder.py b/giftwrap/builders/docker_builder.py index 0711138..13ec6a9 100644 --- a/giftwrap/builders/docker_builder.py +++ b/giftwrap/builders/docker_builder.py @@ -111,7 +111,8 @@ class DockerBuilder(Builder): self.envvars['PATH'] = "%s:$PATH" % path def _render_dockerfile(self, extra_vars): - template_vars = self.__dict__.update(extra_vars) + template_vars = self.__dict__ + template_vars.update(extra_vars) template_loader = jinja2.FileSystemLoader(searchpath='/') template_env = jinja2.Environment(loader=template_loader) template = template_env.get_template(self.template)