giftwrap/c16cc483183290aa84071eae22d491573de469e7

{
  "comments": [
    {
      "key": {
        "uuid": "7aa08908_3b1b321e",
        "filename": "giftwrap/builders/__init__.py",
        "patchSetId": 2
      },
      "lineNbr": 63,
      "author": {
        "id": 6530
      },
      "writtenOn": "2016-06-10T16:29:15Z",
      "side": 1,
      "message": "Nits, but not sure why there are lines between the code and prefer more descriptive variable names.",
      "revId": "c16cc483183290aa84071eae22d491573de469e7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7aa08908_8d3781af",
        "filename": "giftwrap/builders/__init__.py",
        "patchSetId": 2
      },
      "lineNbr": 63,
      "author": {
        "id": 6589
      },
      "writtenOn": "2016-06-10T19:05:14Z",
      "side": 1,
      "message": "Ah, well, it wasn\u0027t quite so spaced out when I first submitted. It got spaced out as I responded to review. I can definitely clean it back up, and use more descriptive names.",
      "parentUuid": "7aa08908_3b1b321e",
      "revId": "c16cc483183290aa84071eae22d491573de469e7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7aa08908_bb0722c8",
        "filename": "giftwrap/builders/__init__.py",
        "patchSetId": 2
      },
      "lineNbr": 106,
      "author": {
        "id": 6530
      },
      "writtenOn": "2016-06-10T16:29:15Z",
      "side": 1,
      "message": "This will pull the URL for every project.  Shouldn\u0027t this be per-build?",
      "revId": "c16cc483183290aa84071eae22d491573de469e7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7aa08908_cd5869fd",
        "filename": "giftwrap/builders/__init__.py",
        "patchSetId": 2
      },
      "lineNbr": 106,
      "author": {
        "id": 6589
      },
      "writtenOn": "2016-06-10T19:05:14Z",
      "side": 1,
      "message": "Ah, I did this wrong then. For this first pass, yes I wanted the constraints load to be per-build, not per project. I stuffed the code into the wrong place obviously. I\u0027ll move it around.",
      "parentUuid": "7aa08908_bb0722c8",
      "revId": "c16cc483183290aa84071eae22d491573de469e7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7aa08908_5e20ac49",
        "filename": "giftwrap/builders/docker_builder.py",
        "patchSetId": 2
      },
      "lineNbr": 67,
      "author": {
        "id": 6530
      },
      "writtenOn": "2016-06-10T16:29:15Z",
      "side": 1,
      "message": "This is pretty good :) We should probably fix that.",
      "revId": "c16cc483183290aa84071eae22d491573de469e7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7aa08908_0d739181",
        "filename": "giftwrap/builders/docker_builder.py",
        "patchSetId": 2
      },
      "lineNbr": 67,
      "author": {
        "id": 6589
      },
      "writtenOn": "2016-06-10T19:05:14Z",
      "side": 1,
      "message": "Indeed, however that\u0027s beyond the scope of this change request :)",
      "parentUuid": "7aa08908_5e20ac49",
      "revId": "c16cc483183290aa84071eae22d491573de469e7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7aa08908_3bc5f23c",
        "filename": "giftwrap/builders/docker_builder.py",
        "patchSetId": 2
      },
      "lineNbr": 88,
      "author": {
        "id": 6530
      },
      "writtenOn": "2016-06-10T16:29:15Z",
      "side": 1,
      "message": "I\u0027d rather see this as a property of a Builder:\n\n@property\ndef uses_contraints(self):\n    return self._constraints_path\n\nReason being is that there may be other directives that would invoke the use of \"-c\"",
      "revId": "c16cc483183290aa84071eae22d491573de469e7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "7aa08908_cd0fc9df",
        "filename": "giftwrap/builders/docker_builder.py",
        "patchSetId": 2
      },
      "lineNbr": 88,
      "author": {
        "id": 6589
      },
      "writtenOn": "2016-06-10T19:05:14Z",
      "side": 1,
      "message": "that makes it a bit awkward, as \"uses_constraints\" sounds like a boolean, and yet what you\u0027re returning is a path. I can do that, just feels a tad awkward.",
      "parentUuid": "7aa08908_3bc5f23c",
      "revId": "c16cc483183290aa84071eae22d491573de469e7",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}