x
/
glare
Code Issues Proposed changes

Fix inconsistent tags ordering. 

set() does not guaranty order is kept, causing index access to fail (for example during update)

Change-Id: I141aee8fe38e39c47ba982a177c47b3c552dd4af
This commit is contained in:
Idan Hefetz 2020-06-10 10:39:56 +00:00
parent 2580e0f4fe
commit 0b382f617e
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glare/objects/meta/validators.py
View File

@ -292,7 +292,7 @@ class Unique(Validator):
def __call__(self, value):
if self.convert_to_set:
value[:] = list(set(value))
value[:] = sorted(list(set(value)))
elif len(value) != len(set(value)):
raise ValueError(_("List items %s must be unique.") % value)