From a0bffe14c08ceb96440c42deb32550a10f863142 Mon Sep 17 00:00:00 2001 From: Jin Li Date: Fri, 3 Nov 2017 15:32:55 -0700 Subject: [PATCH] Remove confusing else statement The append_model() function in the generator.py file has a confusing else statement. There is no need for setting model['file_version'] = yaml_dict['file_version'] as entering the else statement implies they are equal. Change-Id: I5278677ac5890350dfac6d58cc8b04ff91f33849 --- gluon/particleGenerator/generator.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gluon/particleGenerator/generator.py b/gluon/particleGenerator/generator.py index bc03c5b..af30d1f 100644 --- a/gluon/particleGenerator/generator.py +++ b/gluon/particleGenerator/generator.py @@ -309,10 +309,11 @@ def append_model(model, yaml_dict): file_version = yaml_dict.get('file_version') cur_file_version = model.get('file_version') if file_version and cur_file_version: - if file_version != file_version: + if file_version != cur_file_version: raise_format_error('File version mismatch %s', (file_version)) - else: - model['file_version'] = yaml_dict['file_version'] + # no need to re-assign! entering else statement implies they are equal + # else: + # model['file_version'] = yaml_dict['file_version'] elif file_version: model['file_version'] = file_version if 'imports' in yaml_dict: