x
/
golang-client
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(8 comments)

Patch-set: 2
Label: Verified=0
This commit is contained in:
Gerrit User 8512 2014-10-13 14:34:41 +00:00 committed by Gerrit Code Review
parent 4ed2815cbe
commit 1dc1e9b26b
1 changed files with 144 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

144
46d7665c2bc00c744bc1244225b06c6dc7ffe4e8
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_9498d91c",
"filename": "examples/01-authentication-v3.go",
"patchSetId": 2
},
"lineNbr": 15,
"author": {
"id": 8512
},
"writtenOn": "2014-10-13T14:34:41Z",
"side": 1,
"message": "What do you think of moving these tests to the normal go test setup. For example, a user would instead use `go test -integration` to fire off these tests. Then the examples could be in the docs as you suggested elsewhere.\n\nWhat do you think?",
"parentUuid": "baa201ad_85d70623",
"revId": "46d7665c2bc00c744bc1244225b06c6dc7ffe4e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_e2db687b",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_1484e9af",
"filename": "identity/v3/identity.go",
"patchSetId": 2
},
"lineNbr": 1,
"author": {
"id": 8512
},
"writtenOn": "2014-10-13T14:34:41Z",
"side": 1,
"message": "Great catch. I\u0027ll add it.",
"parentUuid": "baa201ad_e2db687b",
"revId": "46d7665c2bc00c744bc1244225b06c6dc7ffe4e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_e294488e",
@ -68,6 +104,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_fa2e6f8b",
"filename": "identity/v3/identity.go",
"patchSetId": 2
},
"lineNbr": 10,
"author": {
"id": 8512
},
"writtenOn": "2014-10-13T14:34:41Z",
"side": 1,
"message": "This is just a partial implementation of V3 support. Trying to break it down into smaller and useful commits.\n\nThe feature request (blueprint as it\u0027s called) is at https://blueprints.launchpad.net/golang-client/+spec/identity-v3. You\u0027ll notice in the commit message I say it partially implements the support.\n\nSo, yes... more support is to come.",
"parentUuid": "baa201ad_627858f9",
"revId": "46d7665c2bc00c744bc1244225b06c6dc7ffe4e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_8208dc92",
@ -102,6 +156,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_1a74139b",
"filename": "identity/v3/identity.go",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 8512
},
"writtenOn": "2014-10-13T14:34:41Z",
"side": 1,
"message": "I\u0027m not sure I understand what you mean. Can you explain?",
"parentUuid": "baa201ad_82ba9cbe",
"revId": "46d7665c2bc00c744bc1244225b06c6dc7ffe4e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_02c06c7b",
@ -119,6 +191,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_dabd2b04",
"filename": "identity/v3/identity.go",
"patchSetId": 2
},
"lineNbr": 40,
"author": {
"id": 8512
},
"writtenOn": "2014-10-13T14:34:41Z",
"side": 1,
"message": "I was hoping to build out some V3 support. Then go back and rewrite the v2 support to be similar. Maybe they can even share an interface.",
"parentUuid": "baa201ad_02c06c7b",
"revId": "46d7665c2bc00c744bc1244225b06c6dc7ffe4e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_3c175656",
@ -136,6 +226,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_3ad39760",
"filename": "identity/v3/identity.go",
"patchSetId": 2
},
"lineNbr": 41,
"author": {
"id": 8512
},
"writtenOn": "2014-10-13T14:34:41Z",
"side": 1,
"message": "Some validation should happen here. We need to make sure to validate that we have what we need. We shouldn\u0027t validate the data itself as the API endpoint ultimately does the content validation. We don\u0027t want to be stricter than the API endpoint validation.",
"parentUuid": "baa201ad_3c175656",
"revId": "46d7665c2bc00c744bc1244225b06c6dc7ffe4e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_1c545220",
@ -170,6 +278,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_3aec7729",
"filename": "identity/v3/identity.go",
"patchSetId": 2
},
"lineNbr": 69,
"author": {
"id": 8512
},
"writtenOn": "2014-10-13T14:34:41Z",
"side": 1,
"message": "There are two things here.\n\nFirst, the misc util library is part of the legacy codebase. I\u0027m not sure what\u0027s needed and what we can remove. It goes with the identity v2 codebase that should eventually be replaced with something in better shape.\n\nSecond, identity POST requests to get a token don\u0027t have some of the other parts (eg., the token in the headers). I was waiting until I got to that point to see how it plays out for simplicity.",
"parentUuid": "baa201ad_42199478",
"revId": "46d7665c2bc00c744bc1244225b06c6dc7ffe4e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_e238c8d6",
@ -186,6 +312,24 @@
"revId": "46d7665c2bc00c744bc1244225b06c6dc7ffe4e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "baa201ad_1a9b33ca",
"filename": "identity/v3/identity.go",
"patchSetId": 2
},
"lineNbr": 84,
"author": {
"id": 8512
},
"writtenOn": "2014-10-13T14:34:41Z",
"side": 1,
"message": "Good catch. I\u0027ll add better error handling.",
"parentUuid": "baa201ad_e238c8d6",
"revId": "46d7665c2bc00c744bc1244225b06c6dc7ffe4e8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}