x
/
golang-client
Code Issues Proposed changes

Update patch set 1 

Patch Set 1: Code-Review-1

(3 comments)

Patch-set: 1
Reviewer: Gerrit User 10873 <10873@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 10873 2017-04-24 11:51:21 +00:00 committed by Gerrit Code Review
parent b3550a1861
commit 61d5fbb5d2
1 changed files with 61 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

61
83f5300ed3c00dc87ebd482ebbcd0a3e23cc12f5 Normal file
View File

@ -0,0 +1,61 @@
{
"comments": [
{
"key": {
"uuid": "5ff73747_cabc64bd",
"filename": "examples/authentication-v3/authentication-v3.go",
"patchSetId": 1
},
"lineNbr": 22,
"author": {
"id": 10873
},
"writtenOn": "2017-04-24T11:51:21Z",
"side": 1,
"message": "might want to remove these comments.",
"range": {
"startLine": 21,
"startChar": 0,
"endLine": 22,
"endChar": 10
},
"revId": "83f5300ed3c00dc87ebd482ebbcd0a3e23cc12f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_ea2a80e5",
"filename": "openstack/v3/auth-password-v3.go",
"patchSetId": 1
},
"lineNbr": 90,
"author": {
"id": 10873
},
"writtenOn": "2017-04-24T11:51:21Z",
"side": 1,
"message": "the default domain name is Default. the id is \"default\". So this is wrong.\n\nAlso, would be good to not hardcode this.",
"revId": "83f5300ed3c00dc87ebd482ebbcd0a3e23cc12f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "5ff73747_2a4868ca",
"filename": "openstack/v3/auth-password-v3.go",
"patchSetId": 1
},
"lineNbr": 102,
"author": {
"id": 10873
},
"writtenOn": "2017-04-24T11:51:21Z",
"side": 1,
"message": "same",
"revId": "83f5300ed3c00dc87ebd482ebbcd0a3e23cc12f5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}