Update patch set 4
Patch Set 4: Code-Review+1 (8 comments) Fixing up places where I need public comments and reviewing the api further. Patch-set: 4 Label: Code-Review=+1
This commit is contained in:
parent
6c2049d9dc
commit
f060eec67c
140
a503591e0af2c756457a5e14985ed5abf656c44a
Normal file
140
a503591e0af2c756457a5e14985ed5abf656c44a
Normal file
@ -0,0 +1,140 @@
|
|||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "9aa7fdbe_7e5294de",
|
||||||
|
"filename": "examples/30-image-v1.go",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 17,
|
||||||
|
"author": {
|
||||||
|
"id": 13475
|
||||||
|
},
|
||||||
|
"writtenOn": "2014-10-20T23:07:23Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Verified scenario works against HP Helion public cloud",
|
||||||
|
"revId": "a503591e0af2c756457a5e14985ed5abf656c44a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "9aa7fdbe_deab8087",
|
||||||
|
"filename": "image/v1/image.go",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 32,
|
||||||
|
"author": {
|
||||||
|
"id": 13475
|
||||||
|
},
|
||||||
|
"writtenOn": "2014-10-20T23:07:23Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "type comments needed",
|
||||||
|
"revId": "a503591e0af2c756457a5e14985ed5abf656c44a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "9aa7fdbe_9ea1f8ab",
|
||||||
|
"filename": "image/v1/image.go",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 41,
|
||||||
|
"author": {
|
||||||
|
"id": 13475
|
||||||
|
},
|
||||||
|
"writtenOn": "2014-10-20T23:07:23Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "type comments needed",
|
||||||
|
"revId": "a503591e0af2c756457a5e14985ed5abf656c44a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "9aa7fdbe_5ec87074",
|
||||||
|
"filename": "image/v1/image.go",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 148,
|
||||||
|
"author": {
|
||||||
|
"id": 13475
|
||||||
|
},
|
||||||
|
"writtenOn": "2014-10-20T23:07:23Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "No comments outlining what this is, need to fix",
|
||||||
|
"revId": "a503591e0af2c756457a5e14985ed5abf656c44a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "9aa7fdbe_de0c6097",
|
||||||
|
"filename": "image/v1/image_test.go",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 105,
|
||||||
|
"author": {
|
||||||
|
"id": 13475
|
||||||
|
},
|
||||||
|
"writtenOn": "2014-10-20T23:07:23Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "This variable name is wrong, its fixed for the next iteration",
|
||||||
|
"revId": "a503591e0af2c756457a5e14985ed5abf656c44a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "9aa7fdbe_dee8e07e",
|
||||||
|
"filename": "misc/customTypes.go",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 43,
|
||||||
|
"author": {
|
||||||
|
"id": 13475
|
||||||
|
},
|
||||||
|
"writtenOn": "2014-10-20T23:07:23Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Add comment",
|
||||||
|
"revId": "a503591e0af2c756457a5e14985ed5abf656c44a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "9aa7fdbe_feeda48c",
|
||||||
|
"filename": "misc/util.go",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 27,
|
||||||
|
"author": {
|
||||||
|
"id": 13475
|
||||||
|
},
|
||||||
|
"writtenOn": "2014-10-20T23:07:23Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Add comments",
|
||||||
|
"revId": "a503591e0af2c756457a5e14985ed5abf656c44a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "9aa7fdbe_be9a3c12",
|
||||||
|
"filename": "testUtil/testUtil.go",
|
||||||
|
"patchSetId": 4
|
||||||
|
},
|
||||||
|
"lineNbr": 49,
|
||||||
|
"author": {
|
||||||
|
"id": 13475
|
||||||
|
},
|
||||||
|
"writtenOn": "2014-10-20T23:07:23Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "add comment",
|
||||||
|
"revId": "a503591e0af2c756457a5e14985ed5abf656c44a",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue
Block a user