Fix python namespacing

Use namespaces when referencing python packages. Also, as per
https://review.opendev.org/#/c/527320/, replace all references to
django.core.urlresolves with django.urls.

Change-Id: I6460d0734aa11ffa44f259baa7155d2a202f7162
This commit is contained in:
Thomas Bachman
2020-11-02 18:40:07 +00:00
committed by Thomas Bachman
parent 7358921b34
commit 4ad1cf5ca6
27 changed files with 53 additions and 50 deletions

View File

@@ -13,7 +13,7 @@
import os import os
from django.conf import settings from django.conf import settings
from django.core.urlresolvers import reverse from django.urls import reverse
from django.utils.safestring import mark_safe from django.utils.safestring import mark_safe
from gbpui import client from gbpui import client

View File

@@ -14,7 +14,7 @@
from horizon import forms from horizon import forms
from django.core.urlresolvers import reverse from django.urls import reverse
class ReversingModalFormView(forms.ModalFormView): class ReversingModalFormView(forms.ModalFormView):

View File

@@ -12,7 +12,8 @@
from itertools import chain from itertools import chain
from django.core import urlresolvers from django import urls
from django.forms import fields from django.forms import fields
from django.forms import TextInput from django.forms import TextInput
from django.forms import widgets from django.forms import widgets
@@ -43,11 +44,11 @@ class DynamicMultiSelectWidget(widgets.SelectMultiple):
return self.add_item_link() return self.add_item_link()
try: try:
if self.add_item_link_args: if self.add_item_link_args:
return urlresolvers.reverse(self.add_item_link, return urls.reverse(self.add_item_link,
args=self.add_item_link_args) args=self.add_item_link_args)
else: else:
return urlresolvers.reverse(self.add_item_link) return urls.reverse(self.add_item_link)
except urlresolvers.NoReverseMatch: except urls.NoReverseMatch:
return self.add_item_link return self.add_item_link
@@ -116,7 +117,7 @@ class TransferTableWidget(widgets.SelectMultiple):
options = self.render_options(choices, selected) options = self.render_options(choices, selected)
if self.add_item_link is not None: if self.add_item_link is not None:
final_attrs['add_item_link'] = urlresolvers.reverse( final_attrs['add_item_link'] = urls.reverse(
self.add_item_link self.add_item_link
) )

View File

@@ -10,9 +10,9 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from django.core.urlresolvers import reverse
from django import http from django import http
from django.template.defaultfilters import filesizeformat # noqa from django.template.defaultfilters import filesizeformat # noqa
from django.urls import reverse
from django.utils import html from django.utils import html
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from django.views.decorators.debug import sensitive_variables # noqa from django.views.decorators.debug import sensitive_variables # noqa

View File

@@ -10,7 +10,7 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from django.core.urlresolvers import reverse from django.urls import reverse
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from django.utils.translation import ungettext_lazy from django.utils.translation import ungettext_lazy

View File

@@ -10,7 +10,7 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from django.core.urlresolvers import reverse_lazy from django.urls import reverse_lazy
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from horizon import exceptions from horizon import exceptions
@@ -19,7 +19,7 @@ from horizon import tabs
from gbpui import client from gbpui import client
from gbpui import column_filters as gfilters from gbpui import column_filters as gfilters
import tables from gbpui.panels.application_policy import tables
PolicyRulesTable = tables.PolicyRulesTable PolicyRulesTable = tables.PolicyRulesTable
PolicyClassifiersTable = tables.PolicyClassifiersTable PolicyClassifiersTable = tables.PolicyClassifiersTable

View File

@@ -13,7 +13,7 @@
from django.conf.urls import url # noqa from django.conf.urls import url # noqa
import views from gbpui.panels.application_policy import views
urlpatterns = [ urlpatterns = [
url(r'^$', views.IndexView.as_view(), name='index'), url(r'^$', views.IndexView.as_view(), name='index'),

View File

@@ -9,14 +9,15 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from django.core.urlresolvers import reverse
from django.urls import reverse
from horizon import tabs from horizon import tabs
from horizon import workflows from horizon import workflows
import forms as policy_rule_set_forms from gbpui.panels.application_policy import forms as policy_rule_set_forms
import tabs as policy_rule_set_tabs from gbpui.panels.application_policy import tabs as policy_rule_set_tabs
import workflows as policy_rule_set_workflows from gbpui.panels.application_policy import workflows as prs_workflows
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from gbpui.common import forms as gbforms from gbpui.common import forms as gbforms
@@ -26,9 +27,9 @@ PolicyRuleSetDetailsTabs = policy_rule_set_tabs.PolicyRuleSetDetailsTabs
PolicyRuleDetailsTabs = policy_rule_set_tabs.PolicyRuleDetailsTabs PolicyRuleDetailsTabs = policy_rule_set_tabs.PolicyRuleDetailsTabs
PolicyClassifierDetailsTabs = policy_rule_set_tabs.PolicyClassifierDetailsTabs PolicyClassifierDetailsTabs = policy_rule_set_tabs.PolicyClassifierDetailsTabs
PolicyActionDetailsTabs = policy_rule_set_tabs.PolicyActionDetailsTabs PolicyActionDetailsTabs = policy_rule_set_tabs.PolicyActionDetailsTabs
AddPolicyRuleSet = policy_rule_set_workflows.AddContract AddPolicyRuleSet = prs_workflows.AddContract
AddPolicyRule = policy_rule_set_workflows.AddPolicyRule AddPolicyRule = prs_workflows.AddPolicyRule
AddPolicyClassifier = policy_rule_set_workflows.AddPolicyClassifier AddPolicyClassifier = prs_workflows.AddPolicyClassifier
class IndexView(tabs.TabbedTableView): class IndexView(tabs.TabbedTableView):

View File

@@ -10,7 +10,7 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from django.core.urlresolvers import reverse from django.urls import reverse
from django.utils import html from django.utils import html
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _

View File

@@ -12,9 +12,9 @@
import logging import logging
from django.core.urlresolvers import reverse
from django import http from django import http
from django import shortcuts from django import shortcuts
from django.urls import reverse
from django.utils import html from django.utils import html
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _

View File

@@ -10,7 +10,7 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from django.core.urlresolvers import reverse from django.urls import reverse
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from django.utils.translation import ungettext_lazy from django.utils.translation import ungettext_lazy

View File

@@ -10,7 +10,7 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from django.core.urlresolvers import reverse_lazy from django.urls import reverse_lazy
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from horizon import exceptions from horizon import exceptions
@@ -19,7 +19,7 @@ from horizon import tabs
from gbpui import client from gbpui import client
from gbpui import column_filters as gfilters from gbpui import column_filters as gfilters
import tables from gbpui.panels.network_policy import tables
class L3PolicyDetailsTab(tabs.Tab): class L3PolicyDetailsTab(tabs.Tab):

View File

@@ -13,7 +13,7 @@
from django.conf.urls import url # noqa from django.conf.urls import url # noqa
import views from gbpui.panels.network_policy import views
urlpatterns = [ urlpatterns = [
url(r'^$', views.IndexView.as_view(), name='index'), url(r'^$', views.IndexView.as_view(), name='index'),

View File

@@ -9,7 +9,8 @@
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the # WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from django.core.urlresolvers import reverse
from django.urls import reverse
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from horizon import exceptions from horizon import exceptions
@@ -19,9 +20,9 @@ from horizon import tabs
from gbpui import client from gbpui import client
from gbpui.common import forms as gbforms from gbpui.common import forms as gbforms
import forms as np_forms from gbpui.panels.network_policy import forms as np_forms
import tables as np_tables from gbpui.panels.network_policy import tables as np_tables
import tabs as np_tabs from gbpui.panels.network_policy import tabs as np_tabs
class IndexView(tabs.TabbedTableView): class IndexView(tabs.TabbedTableView):

View File

@@ -13,7 +13,7 @@
import json import json
import logging import logging
from django.core.urlresolvers import reverse from django.urls import reverse
from django.utils import html from django.utils import html
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _

View File

@@ -10,7 +10,7 @@
# License for the specific language governing permissions and limitations # License for the specific language governing permissions and limitations
# under the License. # under the License.
from django.core.urlresolvers import reverse from django.urls import reverse
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from django.utils.translation import ungettext_lazy from django.utils.translation import ungettext_lazy

View File

@@ -12,12 +12,12 @@
import json import json
import tables as ns_tables from gbpui.panels.network_services import tables as ns_tables
import yaml import yaml
from django.contrib.staticfiles.templatetags.staticfiles import static from django.contrib.staticfiles.templatetags.staticfiles import static
from django.core.urlresolvers import reverse_lazy from django.urls import reverse_lazy
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from horizon import exceptions from horizon import exceptions

View File

@@ -12,7 +12,7 @@
from django.conf.urls import url # noqa from django.conf.urls import url # noqa
import views from gbpui.panels.network_services import views
urlpatterns = [ urlpatterns = [
url(r'^$', views.IndexView.as_view(), name='index'), url(r'^$', views.IndexView.as_view(), name='index'),

View File

@@ -12,8 +12,8 @@
from horizon import forms from horizon import forms
from horizon import tabs from horizon import tabs
import forms as ns_forms from gbpui.panels.network_services import forms as ns_forms
import tabs as ns_tabs from gbpui.panels.network_services import tabs as ns_tabs
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from gbpui.common import forms as gbforms from gbpui.common import forms as gbforms

View File

@@ -12,8 +12,8 @@
import logging import logging
from django.core.urlresolvers import reverse
from django import http from django import http
from django.urls import reverse
from django.utils import html from django.utils import html
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _

View File

@@ -11,9 +11,9 @@
# under the License. # under the License.
import logging import logging
from django.core.urlresolvers import reverse
from django import http from django import http
from django import shortcuts from django import shortcuts
from django.urls import reverse
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from django.utils.translation import ungettext_lazy from django.utils.translation import ungettext_lazy

View File

@@ -12,9 +12,9 @@
import time import time
import tables from gbpui.panels.policytargets import tables
from django.core.urlresolvers import reverse_lazy from django.urls import reverse_lazy
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from horizon import exceptions from horizon import exceptions

View File

@@ -12,9 +12,9 @@
from django.conf.urls import url # noqa from django.conf.urls import url # noqa
import views from gbpui.panels.policytargets import views
import restApi from gbpui.panels.policytargets import restApi
urlpatterns = [ urlpatterns = [
url(r'^$', url(r'^$',

View File

@@ -12,8 +12,8 @@
import json import json
from django.core.urlresolvers import reverse_lazy
from django.http import HttpResponse # noqa from django.http import HttpResponse # noqa
from django.urls import reverse_lazy
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _
from horizon import exceptions from horizon import exceptions
@@ -25,9 +25,9 @@ from gbpui import client
from gbpui.common import forms as gbforms from gbpui.common import forms as gbforms
import forms as policy_target_forms import gbpui.panels.policytargets.forms as policy_target_forms
import tabs as policy_target_tabs import gbpui.panels.policytargets.tabs as policy_target_tabs
import workflows as policy_target_workflows import gbpui.panels.policytargets.workflows as policy_target_workflows
from openstack_dashboard import api from openstack_dashboard import api

View File

@@ -14,8 +14,8 @@ import logging
import re import re
from django.conf import settings from django.conf import settings
from django.core.urlresolvers import reverse
from django import shortcuts from django import shortcuts
from django.urls import reverse
from django.utils import html from django.utils import html
from django.utils.text import normalize_newlines # noqa from django.utils.text import normalize_newlines # noqa
from django.utils.translation import ugettext_lazy as _ from django.utils.translation import ugettext_lazy as _

View File

@@ -7,7 +7,7 @@
# be installed in a specific order. # be installed in a specific order.
# #
# Hacking should appear first in case something else depends on pep8 # Hacking should appear first in case something else depends on pep8
hacking>=1.1.0,<2 # Apache-2.0 hacking>=3.0.1,<3.1.0 # Apache-2.0
# remove this pyflakes from here once you bump the # remove this pyflakes from here once you bump the
# hacking to 3.2.0 or above. hacking 3.2.0 takes # hacking to 3.2.0 or above. hacking 3.2.0 takes
# care of pyflakes version compatibilty. # care of pyflakes version compatibilty.

View File

@@ -1,6 +1,6 @@
[tox] [tox]
envlist = pep8,py35,py36,py37,py3-dj111 envlist = pep8,py36,py37,py38,py3-dj111
minversion = 2.3.2 minversion = 3.1
skipsdist = True skipsdist = True
[testenv] [testenv]