x/group-based-policy
Code Issues Proposed changes

Remove explicit ep_move_detect_mode config

Browse Source 
The AIM BridgeDomain resource was being configured with an
explicit value of the ep_move_detect_mode parameter. This was
done to address a workaround needed for older hardware. Now
that the older hardware is no longer supported, AIM has been
changed to disable this value by default, which means that the
AIM mechanism driver no longer needs to set this value explicilty.

Change-Id: I41036952c46bfd72e0c9ed2416fcf3af6294c9ad
This commit is contained in:
Thomas Bachman 2023-12-07 22:57:48 +00:00
parent 36d9857be5
commit 727abc5c47
2 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
gbpservice/neutron/plugins/ml2plus/drivers/apic_aim/mechanism_driver.py
View File

@ -948,16 +948,12 @@ class ApicMechanismDriver(api_plus.MechanismDriver,
bd.enable_arp_flood = True
bd.enable_routing = False
bd.limit_ip_learn_to_subnets = True
# REVISIT(rkukura): When AIM changes default
# ep_move_detect_mode value to 'garp', remove it here.
bd.ep_move_detect_mode = 'garp'
if preexisting_bd:
bd = self.aim.update(aim_ctx, preexisting_bd,
display_name=bd.display_name, vrf_name=bd.vrf_name,
enable_arp_flood=bd.enable_arp_flood,
enable_routing=bd.enable_routing,
limit_ip_learn_to_subnets=bd.limit_ip_learn_to_subnets,
ep_move_detect_mode=bd.ep_move_detect_mode,
monitored=False)
epg.bd_name = preexisting_bd.name
else:
@ -7535,7 +7531,7 @@ class ApicMechanismDriver(api_plus.MechanismDriver,
bd.enable_arp_flood = True
bd.enable_routing = len(router_contract_names) is not 0
bd.limit_ip_learn_to_subnets = True
bd.ep_move_detect_mode = 'garp'
bd.ep_move_detect_mode = ''
bd.l3out_names = []
bd.monitored = False
mgr.expect_aim_resource(bd)

2
gbpservice/neutron/tests/unit/plugins/ml2plus/test_apic_aim.py
View File

@ -1207,7 +1207,7 @@ class TestAimMapping(ApicAimTestCase):
self.assertFalse(aim_bd.enable_routing)
self.assertTrue(aim_bd.limit_ip_learn_to_subnets)
self.assertEqual('proxy', aim_bd.l2_unknown_unicast_mode)
self.assertEqual('garp', aim_bd.ep_move_detect_mode)
self.assertEqual('', aim_bd.ep_move_detect_mode)
self._check_dn_is_resource(dns, 'BridgeDomain', aim_bd)
aim_epg = self._get_epg(aname, tenant_aname,