51 lines
1.9 KiB
Plaintext
51 lines
1.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_76b72f23",
|
|
"filename": "intel_nfv_ci_tests/tests/utils.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 55,
|
|
"author": {
|
|
"id": 15334
|
|
},
|
|
"writtenOn": "2018-10-08T16:32:59Z",
|
|
"side": 1,
|
|
"message": "This has \u0027test_connection_auth\u0027 function [1] that I highly recommend you call. Without this, we have to suffer through a 300 second delay only to get a load of noise [2]. Also, we should probably make those options \u0027required\u0027 *and* manually check that they are set because \u0027required\u0027 doesn\u0027t currently do anything for non-CLI options [3]\n\n[1] https://github.com/openstack/tempest/blob/19.0.0/tempest/lib/common/ssh.py#L205-L208\n[2] http://paste.openstack.org/show/731695/\n[3] https://bugs.launchpad.net/oslo.config/+bug/1735790",
|
|
"range": {
|
|
"startLine": 53,
|
|
"startChar": 0,
|
|
"endLine": 55,
|
|
"endChar": 65
|
|
},
|
|
"revId": "4793c5d7a6c3ae32ab422ed3a845f2d1dccc1a32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_a3706443",
|
|
"filename": "intel_nfv_ci_tests/tests/utils.py",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 55,
|
|
"author": {
|
|
"id": 28014
|
|
},
|
|
"writtenOn": "2018-10-17T09:32:36Z",
|
|
"side": 1,
|
|
"message": "done timeout is set to 50 because tempest uses 10 seconds per ssh connect try (channel_timeout) and I wanted to make it try for 5 times",
|
|
"parentUuid": "3f79a3b5_76b72f23",
|
|
"range": {
|
|
"startLine": 53,
|
|
"startChar": 0,
|
|
"endLine": 55,
|
|
"endChar": 65
|
|
},
|
|
"revId": "4793c5d7a6c3ae32ab422ed3a845f2d1dccc1a32",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |