Update patch set 9

Patch Set 9:

(5 comments)

Patch-set: 9
Reviewer: Gerrit User 18893 <18893@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0

986d47569d7960f4ecb1d66639d060d588dfa8bb

@@ -0,0 +1,21 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3a57f1b5_62cc736a",
+        "filename": "ironic_staging_drivers/tests/base.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 3,
+      "author": {
+        "id": 18893
+      },
+      "writtenOn": "2016-02-12T11:26:26Z",
+      "side": 0,
+      "message": "Should deleting this file be part of this changeset?",
+      "revId": "986d47569d7960f4ecb1d66639d060d588dfa8bb",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}

b33b0d9597ccb793bb2175e7093a869a1e54f2eb

@@ -0,0 +1,72 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "3a57f1b5_bf9b6465",
+        "filename": "ironic_staging_drivers/common/exception.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 19,
+      "author": {
+        "id": 18893
+      },
+      "writtenOn": "2016-02-12T11:26:26Z",
+      "side": 1,
+      "message": "PEP 8 says to capitalize all letters of abbreviations in class names: https://www.python.org/dev/peps/pep-0008/#descriptive-naming-styles. So this should be WOLOperationError rather than WolOperationError. Though WakeOnLanOperationError might be even better, not least because it wouldn\u0027t make me think of the Winnie-the-Pooh character :-) https://en.wikipedia.org/wiki/List_of_Winnie-the-Pooh_characters#Owl",
+      "revId": "b33b0d9597ccb793bb2175e7093a869a1e54f2eb",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3a57f1b5_82cdef86",
+        "filename": "ironic_staging_drivers/fake.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 22,
+      "author": {
+        "id": 18893
+      },
+      "writtenOn": "2016-02-12T11:26:26Z",
+      "side": 1,
+      "message": "I don\u0027t think you want two \"Fake\"s in the name. I\u0027d suggest FakeWakeOnLanDriver.",
+      "revId": "b33b0d9597ccb793bb2175e7093a869a1e54f2eb",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3a57f1b5_6228f3e2",
+        "filename": "ironic_staging_drivers/tests/unit/wol/test_power.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 119,
+      "author": {
+        "id": 18893
+      },
+      "writtenOn": "2016-02-12T11:26:26Z",
+      "side": 1,
+      "message": "I think \u0027expected_packet\u0027 would be a better name. And maybe include a link to where this value comes from in a comment?",
+      "revId": "b33b0d9597ccb793bb2175e7093a869a1e54f2eb",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "3a57f1b5_e2ef0385",
+        "filename": "ironic_staging_drivers/wol/power.py",
+        "patchSetId": 9
+      },
+      "lineNbr": 141,
+      "author": {
+        "id": 18893
+      },
+      "writtenOn": "2016-02-12T11:26:26Z",
+      "side": 1,
+      "message": "Is \"just log it\" really the right thing to do?",
+      "revId": "b33b0d9597ccb793bb2175e7093a869a1e54f2eb",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}