x
/
ironic-staging-drivers
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(4 comments)

Patch-set: 9
Label: Verified=0
This commit is contained in:
Gerrit User 6773 2016-02-16 11:01:16 +00:00 committed by Gerrit Code Review
parent cfc8df8a05
commit 8722ba5852
2 changed files with 72 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
986d47569d7960f4ecb1d66639d060d588dfa8bb
View File

@ -16,6 +16,24 @@
"revId": "986d47569d7960f4ecb1d66639d060d588dfa8bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dae33548_b029188c",
"filename": "ironic_staging_drivers/tests/base.py",
"patchSetId": 9
},
"lineNbr": 3,
"author": {
"id": 6773
},
"writtenOn": "2016-02-16T11:01:16Z",
"side": 0,
"message": "It was a placeholder generated by a cookiecutter[0], we didn\u0027t have any unittests so I left it there. But since this patch is adding the first unittests of this project I think we should get rid of this file\n\n[0] https://github.com/openstack-dev/cookiecutter",
"parentUuid": "3a57f1b5_62cc736a",
"revId": "986d47569d7960f4ecb1d66639d060d588dfa8bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}

54
b33b0d9597ccb793bb2175e7093a869a1e54f2eb
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dae33548_2d692f26",
"filename": "ironic_staging_drivers/common/exception.py",
"patchSetId": 9
},
"lineNbr": 19,
"author": {
"id": 6773
},
"writtenOn": "2016-02-16T11:01:16Z",
"side": 1,
"message": "Done",
"parentUuid": "3a57f1b5_bf9b6465",
"revId": "b33b0d9597ccb793bb2175e7093a869a1e54f2eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a57f1b5_82cdef86",
@ -52,6 +70,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dae33548_4db1138f",
"filename": "ironic_staging_drivers/fake.py",
"patchSetId": 9
},
"lineNbr": 22,
"author": {
"id": 6773
},
"writtenOn": "2016-02-16T11:01:16Z",
"side": 1,
"message": "@Tan, exactly!\n\nYeah that\u0027s to keep the template suggested for the driver\u0027s name \u003cboot\u003e_\u003cpower\u003e_\u003cdeploy\u003e",
"parentUuid": "dae33548_ceeef4eb",
"revId": "b33b0d9597ccb793bb2175e7093a869a1e54f2eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a57f1b5_6228f3e2",
@ -85,6 +121,24 @@
"revId": "b33b0d9597ccb793bb2175e7093a869a1e54f2eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "dae33548_70baf00b",
"filename": "ironic_staging_drivers/wol/power.py",
"patchSetId": 9
},
"lineNbr": 141,
"author": {
"id": 6773
},
"writtenOn": "2016-02-16T11:01:16Z",
"side": 1,
"message": "Yeah unfortunately... That\u0027s how we have it in ironic now; WOL is not capable of turning the machine off, that\u0027s a limitation of the technology so the best we can do is to LOG and document it.",
"parentUuid": "3a57f1b5_e2ef0385",
"revId": "b33b0d9597ccb793bb2175e7093a869a1e54f2eb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}