x
/
kolla-mesos
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
Reviewer: Gerrit User 14027 <14027@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Verified=0
This commit is contained in:
Gerrit User 14027 2016-03-24 06:30:44 +00:00 committed by Gerrit Code Review
parent dc6a1d2447
commit 7df7a4623a
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
f19b941dffa55c8a1ce8b5ff8be5115861e1c750
View File

@ -22,6 +22,30 @@
"revId": "f19b941dffa55c8a1ce8b5ff8be5115861e1c750",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "fa0719c6_8c073381",
"filename": "kolla_mesos/container_scripts/start.py",
"patchSetId": 1
},
"lineNbr": 198,
"author": {
"id": 14027
},
"writtenOn": "2016-03-24T06:30:44Z",
"side": 1,
"message": "I don\u0027t think so.\n\nFrom what I know, \"decode\" creates the unicode from string, where potential unicode characters are encoded in ascii.\nAnd \"encode\" creates the ascii string from unicode.\n\nThat approach works here and seems to be valid when playing with Python:\n\n In [4]: u\u0027ąęż\u0027.encode(\u0027utf-8\u0027)\n Out[4]: \u0027\\xc4\\x85\\xc4\\x99\\xc5\\xbc\u0027\n\n In [5]: \u0027\\xc4\\x85\\xc4\\x99\\xc5\\xbc\u0027.decode(\u0027utf-8\u0027)\n Out[5]: u\u0027\\u0105\\u0119\\u017c\u0027\n\n In [6]: print u\u0027\\u0105\\u0119\\u017c\u0027\n ąęż",
"parentUuid": "fa0719c6_a518531f",
"range": {
"startLine": 198,
"startChar": 44,
"endLine": 198,
"endChar": 50
},
"revId": "f19b941dffa55c8a1ce8b5ff8be5115861e1c750",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}