x/kosmos-specs
Code Issues Proposed changes

Update patch set 2

Browse Source 
Patch Set 2:

(11 comments)

A few inline comments

Patch-set: 2
Label: Verified=0
This commit is contained in:
Gerrit User 8099 2015-10-06 12:18:14 +00:00 committed by Gerrit Code Review
parent b346d19590
commit ec5d23997d
1 changed files with 198 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

198
d1dc106fb29ccc051c9d8abf84dd861e1616118b
View File

@ -85,6 +85,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_55b95fe8",
"filename": "specs/liberty/sysarch/erd-diagram.dot",
"patchSetId": 2
},
"lineNbr": 7,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "I would push against us co-locating in neutron schema.\n\nWe could be on the same DB servers, but should have a separate schema. \n\nWe will also need to move this state globally at some point, and being inside a neutron DB would be ... problematic.",
"parentUuid": "7a2fa921_85adac33",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_50e4343a",
@ -102,6 +120,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_1593e75c",
"filename": "specs/liberty/sysarch/erd-diagram.dot",
"patchSetId": 2
},
"lineNbr": 10,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "OpenStack is moving to project_id these days - we should keep to that standard, and not have a translation layer",
"parentUuid": "7a2fa921_50e4343a",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_42e77f40",
@ -119,6 +155,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_d5e24f9f",
"filename": "specs/liberty/sysarch/erd-diagram.dot",
"patchSetId": 2
},
"lineNbr": 14,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "Done",
"parentUuid": "7a2fa921_42e77f40",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_301df866",
@ -136,6 +190,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_3582a301",
"filename": "specs/liberty/sysarch/erd-diagram.dot",
"patchSetId": 2
},
"lineNbr": 15,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "yeah, we should.",
"parentUuid": "7a2fa921_301df866",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_2287e362",
@ -170,6 +242,42 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_95f37773",
"filename": "specs/liberty/sysarch/erd-diagram.dot",
"patchSetId": 2
},
"lineNbr": 25,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "Done",
"parentUuid": "7a2fa921_2287e362",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_15a1a794",
"filename": "specs/liberty/sysarch/erd-diagram.dot",
"patchSetId": 2
},
"lineNbr": 25,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "On reflection, probably not. It would be weird to force a plugin to add a value to a DB enum on boot.",
"parentUuid": "7a2fa921_78002bab",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_22ee0323",
@ -187,6 +295,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_35b063dd",
"filename": "specs/liberty/sysarch/erd-diagram.dot",
"patchSetId": 2
},
"lineNbr": 49,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "woops - copy paste fail :/",
"parentUuid": "7a2fa921_22ee0323",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_4aaa4372",
@ -204,6 +330,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_d5c1ef2f",
"filename": "specs/liberty/sysarch/erd-diagram.dot",
"patchSetId": 2
},
"lineNbr": 91,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "/me goes and find the \"trim_whitespace\" setting",
"parentUuid": "7a2fa921_4aaa4372",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_58be8f00",
@ -221,6 +365,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_b5db131b",
"filename": "specs/liberty/sysarch/example-flow.diag",
"patchSetId": 2
},
"lineNbr": 10,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "yup - good catch",
"parentUuid": "7a2fa921_58be8f00",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_65d170fb",
@ -238,6 +400,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_75049b7d",
"filename": "specs/liberty/sysarch/sysarch-diagram-conductor.dot",
"patchSetId": 2
},
"lineNbr": 25,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "Done",
"parentUuid": "7a2fa921_65d170fb",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_653ad0cf",
@ -254,6 +434,24 @@
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "7a2fa921_b5e553a9",
"filename": "specs/liberty/sysarch/sysarch-diagram-overview.dot",
"patchSetId": 2
},
"lineNbr": 34,
"author": {
"id": 8099
},
"writtenOn": "2015-10-06T12:18:14Z",
"side": 1,
"message": "Done",
"parentUuid": "7a2fa921_653ad0cf",
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}