Update patch set 2
Patch Set 2: Code-Review-1 (7 comments) A few comments, but looks good. Patch-set: 2 Label: Code-Review=-1
This commit is contained in:
parent
df604c7a7a
commit
f8050a63b0
123
d1dc106fb29ccc051c9d8abf84dd861e1616118b
Normal file
123
d1dc106fb29ccc051c9d8abf84dd861e1616118b
Normal file
@ -0,0 +1,123 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a2fa921_05d8bc52",
|
||||
"filename": "specs/liberty/sysarch.rst",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 40,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-10-05T16:07:06Z",
|
||||
"side": 1,
|
||||
"message": "We should call out \"GSLB Appliance\" and \"Endpoints\" here to define them for the reader. Maybe highlight that they are not part of Kosmos, but at least define and describe them.",
|
||||
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a2fa921_85adac33",
|
||||
"filename": "specs/liberty/sysarch/erd-diagram.dot",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-10-05T16:07:06Z",
|
||||
"side": 1,
|
||||
"message": "Can we prefix all of these tables with GSLB? That way we can have the flexibility to collocate them in a database with LBaaS/neutron.",
|
||||
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a2fa921_50e4343a",
|
||||
"filename": "specs/liberty/sysarch/erd-diagram.dot",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 10,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-10-05T16:07:06Z",
|
||||
"side": 1,
|
||||
"message": "neutron uses tenant_id",
|
||||
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a2fa921_301df866",
|
||||
"filename": "specs/liberty/sysarch/erd-diagram.dot",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 15,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-10-05T16:07:06Z",
|
||||
"side": 1,
|
||||
"message": "Do we need a field for the ID on the appliance? This might be FQDN on designate, not sure.",
|
||||
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a2fa921_4aaa4372",
|
||||
"filename": "specs/liberty/sysarch/erd-diagram.dot",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 91,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-10-05T16:07:06Z",
|
||||
"side": 1,
|
||||
"message": "Space gremlins",
|
||||
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a2fa921_65d170fb",
|
||||
"filename": "specs/liberty/sysarch/sysarch-diagram-conductor.dot",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 25,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-10-05T16:07:06Z",
|
||||
"side": 1,
|
||||
"message": "Is this arrow backwards?",
|
||||
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "7a2fa921_653ad0cf",
|
||||
"filename": "specs/liberty/sysarch/sysarch-diagram-overview.dot",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 34,
|
||||
"author": {
|
||||
"id": 11628
|
||||
},
|
||||
"writtenOn": "2015-10-05T16:07:06Z",
|
||||
"side": 1,
|
||||
"message": "I struggle a bit with this being dashed. It implies for me that it is out of scope for Kosmos, but I think we plan to have a reference implementation.\nDotted maybe?",
|
||||
"revId": "d1dc106fb29ccc051c9d8abf84dd861e1616118b",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user