Update patch set 11
Patch Set 11: (8 comments) Thanks for the review Dmitrii. I'll have a new version coming soon. Patch-set: 11
This commit is contained in:
Gerrit User 11805
Gerrit Code Review
parent
9cd59b7bf7
commit
0ef403815a
|
|
@ -23,6 +23,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "d92fc830_06124307",
|
||||
"filename": "DEMO.md",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 33,
|
||||
"author": {
|
||||
"id": 11805
|
||||
},
|
||||
"writtenOn": "2021-04-29T19:11:03Z",
|
||||
"side": 1,
|
||||
"message": "Thanks. I put this up since it\u0027s unrelated: https://review.opendev.org/c/x/microstack/+/788816",
|
||||
"parentUuid": "ce3bcd5e_1568fd05",
|
||||
"range": {
|
||||
"startLine": 33,
|
||||
"startChar": 18,
|
||||
"endLine": 33,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "1a47592098d348580f338ef1b06680469db52461",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a33f0b3_23d35ccd",
|
||||
|
|
@ -46,6 +70,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "cb20d8c7_7167473a",
|
||||
"filename": "snap-overlay/templates/05_snap_tweaks.j2",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 46,
|
||||
"author": {
|
||||
"id": 11805
|
||||
},
|
||||
"writtenOn": "2021-04-29T19:11:03Z",
|
||||
"side": 1,
|
||||
"message": "I was thinking this should be able to be remove OPENSTACK_SSL_NO_VERIFY in this patcheset (ie. ensure SSL certificate checks are enabled) but I hadn\u0027t yet figured out how, and that was the reason behind the reminder. They are self-signed certs though so perhaps it won\u0027t be possible. If the latter is the case, then users will need to do this on their own so we\u0027ll likely need to add a config option for it.\n\nIt is defined as:\n\nOPENSTACK_SSL_NO_VERIFY: Disable SSL certificate checks in the OpenStack clients (useful for self-signed certificates).",
|
||||
"parentUuid": "5a33f0b3_23d35ccd",
|
||||
"range": {
|
||||
"startLine": 46,
|
||||
"startChar": 17,
|
||||
"endLine": 46,
|
||||
"endChar": 47
|
||||
},
|
||||
"revId": "1a47592098d348580f338ef1b06680469db52461",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "df46a7df_0f2b7bd4",
|
||||
|
|
@ -69,6 +117,47 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "47548927_7c7b6be5",
|
||||
"filename": "snap-overlay/templates/glance-nginx.conf.j2",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 1,
|
||||
"author": {
|
||||
"id": 11805
|
||||
},
|
||||
"writtenOn": "2021-04-29T19:11:03Z",
|
||||
"side": 1,
|
||||
"message": "Billy did that in a recent commit but now looking at the 2nd link I wonder if this was an issue limited to Python 2.\n\nI would like to consider dropping \"client_max_body_size 0\" from nginx.conf.j2 as well and only setting that here for glance.",
|
||||
"parentUuid": "df46a7df_0f2b7bd4",
|
||||
"range": {
|
||||
"startLine": 1,
|
||||
"startChar": 0,
|
||||
"endLine": 1,
|
||||
"endChar": 6
|
||||
},
|
||||
"revId": "1a47592098d348580f338ef1b06680469db52461",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "83fe3d94_a32b860e",
|
||||
"filename": "snap-overlay/templates/microstack.json.j2",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 20,
|
||||
"author": {
|
||||
"id": 11805
|
||||
},
|
||||
"writtenOn": "2021-04-29T19:11:03Z",
|
||||
"side": 1,
|
||||
"message": "This should get dealt with similar to OPENSTACK_SSL_NO_VERIFY",
|
||||
"revId": "1a47592098d348580f338ef1b06680469db52461",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "05088ee0_c72ad4e3",
|
||||
|
|
@ -86,6 +175,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "f0a0da78_9c0367d7",
|
||||
"filename": "snap-overlay/templates/nova.conf.d.console.conf.j2",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 14,
|
||||
"author": {
|
||||
"id": 11805
|
||||
},
|
||||
"writtenOn": "2021-04-29T19:11:03Z",
|
||||
"side": 1,
|
||||
"message": "Thanks. I may defer that to the next patch and focus on getting openstack endpoints done in this patch.",
|
||||
"parentUuid": "05088ee0_c72ad4e3",
|
||||
"revId": "1a47592098d348580f338ef1b06680469db52461",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "4ea9eac8_fbb725da",
|
||||
|
|
@ -103,6 +210,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5bfa8c46_93619de2",
|
||||
"filename": "tests/test_cluster.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 88,
|
||||
"author": {
|
||||
"id": 11805
|
||||
},
|
||||
"writtenOn": "2021-04-29T19:11:03Z",
|
||||
"side": 1,
|
||||
"message": "I\u0027d like to get the cert transfer automated in this patch so I\u0027ll work on that.",
|
||||
"parentUuid": "4ea9eac8_fbb725da",
|
||||
"revId": "1a47592098d348580f338ef1b06680469db52461",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a5069c4_03b0f5e1",
|
||||
|
|
@ -126,6 +251,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "403ab90b_46545259",
|
||||
"filename": "tools/cluster/cluster/daemon.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 213,
|
||||
"author": {
|
||||
"id": 11805
|
||||
},
|
||||
"writtenOn": "2021-04-29T19:11:03Z",
|
||||
"side": 1,
|
||||
"message": "Ack",
|
||||
"parentUuid": "5a5069c4_03b0f5e1",
|
||||
"range": {
|
||||
"startLine": 213,
|
||||
"startChar": 0,
|
||||
"endLine": 213,
|
||||
"endChar": 72
|
||||
},
|
||||
"revId": "1a47592098d348580f338ef1b06680469db52461",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "bc8be18e_ffa7de41",
|
||||
|
|
@ -142,6 +291,24 @@
|
|||
"revId": "1a47592098d348580f338ef1b06680469db52461",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "72384897_fb139bfa",
|
||||
"filename": "tools/launch/launch/main.py",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 210,
|
||||
"author": {
|
||||
"id": 11805
|
||||
},
|
||||
"writtenOn": "2021-04-29T19:11:03Z",
|
||||
"side": 1,
|
||||
"message": "Ack",
|
||||
"parentUuid": "bc8be18e_ffa7de41",
|
||||
"revId": "1a47592098d348580f338ef1b06680469db52461",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
||||
Loading…
Reference in New Issue