Update patch set 2

Patch Set 2: (5 comments) Patch-set: 2 CC: Gerrit User 24824 <24824@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
2021-10-19 16:44:42 +00:00 · 2021-10-19 16:44:42 +00:00 · 4a3fed556d
parent a65d9ca1c7
commit 4a3fed556d
1 changed files with 113 additions and 0 deletions
--- a/113
+++ b/113
@ -0,0 +1,113 @@
+{
+  "comments": [
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "1f69197b_ab3a3a9f",
+        "filename": "/PATCHSET_LEVEL",
+        "patchSetId": 2
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 24824
+      },
+      "writtenOn": "2021-10-19T16:44:42Z",
+      "side": 1,
+      "message": "Mostly LGTM.\n\nA couple of comments inline.",
+      "revId": "ba1fd62508094f27d1172bb5e700b83fed49560f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "b8443e6c_5deaaa1d",
+        "filename": "tools/cluster/cluster/client.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 167,
+      "author": {
+        "id": 24824
+      },
+      "writtenOn": "2021-10-19T16:44:42Z",
+      "side": 1,
+      "message": "Should probably bump up the API version and handle it slightly differently by expecting an API version error from the clustering service.",
+      "range": {
+        "startLine": 165,
+        "startChar": 0,
+        "endLine": 167,
+        "endChar": 65
+      },
+      "revId": "ba1fd62508094f27d1172bb5e700b83fed49560f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "71f8400b_ac5b51fb",
+        "filename": "tools/cluster/cluster/daemon.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 28,
+      "author": {
+        "id": 24824
+      },
+      "writtenOn": "2021-10-19T16:44:42Z",
+      "side": 1,
+      "message": "We probably need to bump the API version to 1.1.0.\n\nThe new functionality is additive so it wouldn\u0027t break the old clients, however, new clients would expect PKI functionality to be there and request a newer API version explicitly.",
+      "range": {
+        "startLine": 28,
+        "startChar": 0,
+        "endLine": 28,
+        "endChar": 47
+      },
+      "revId": "ba1fd62508094f27d1172bb5e700b83fed49560f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "691f8ba9_65e9faad",
+        "filename": "tools/cluster/cluster/daemon.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 308,
+      "author": {
+        "id": 24824
+      },
+      "writtenOn": "2021-10-19T16:44:42Z",
+      "side": 1,
+      "message": "Should probably compare all components here and error out if a version requested is too new. The old code I have doesn\u0027t properly account for that.",
+      "range": {
+        "startLine": 304,
+        "startChar": 1,
+        "endLine": 308,
+        "endChar": 55
+      },
+      "revId": "ba1fd62508094f27d1172bb5e700b83fed49560f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": true,
+      "key": {
+        "uuid": "a699f737_2d0f01c0",
+        "filename": "tools/cluster/cluster/daemon.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 328,
+      "author": {
+        "id": 24824
+      },
+      "writtenOn": "2021-10-19T16:44:42Z",
+      "side": 1,
+      "message": "Should probably do some error handling here in case the client side doesn\u0027t provide a CSR and raise an appropriate exception for which a handler is defined (app.errorhandler).",
+      "range": {
+        "startLine": 328,
+        "startChar": 0,
+        "endLine": 328,
+        "endChar": 46
+      },
+      "revId": "ba1fd62508094f27d1172bb5e700b83fed49560f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    }
+  ]
+}