Update patch set 2
Patch Set 2: Code-Review-1 (1 comment) I think we could use the native mechanism in glance (see the comment inline). We could also disable proxy buffering so that "Transfer-Encoding: chunked" is handled better: https://cloudblog.switch.ch/2015/08/10/buffering-issues-when-publishing-openstack-dashboard-and-api-services-behind-a-http-reverse-proxy/ https://docs.openstack.org/glance/pike/admin/apache-httpd.html#mod-proxy-uwsgi Limiting the request size at the NGINX level would solve the problem but I would like to discuss the alternative first. Patch-set: 2 Reviewer: Gerrit User 24824 <24824@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Label: Code-Review=-1
This commit is contained in:
parent
b893ff1c3b
commit
50ce8f96fe
|
@ -0,0 +1,27 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "6ad0fb75_cb791c6f",
|
||||
"filename": "snap-overlay/templates/nginx.conf.j2",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 18,
|
||||
"author": {
|
||||
"id": 24824
|
||||
},
|
||||
"writtenOn": "2021-04-20T12:18:01Z",
|
||||
"side": 1,
|
||||
"message": "I propose we use image_size_cap instead:\n\nhttps://docs.openstack.org/glance/latest/configuration/configuring.html#configuring-glance-image-size-limit\n\nand set client_max_body_size to 0 (disabling it).\n\nhttps://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size\n\"Setting size to 0 disables checking of client request body size.\"",
|
||||
"range": {
|
||||
"startLine": 18,
|
||||
"startChar": 0,
|
||||
"endLine": 18,
|
||||
"endChar": 51
|
||||
},
|
||||
"revId": "1fce2529f68833fb4a5864d616134a51ef1d15f1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": true
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue