Update patch set 1

Browse Source

Patch Set 1: Code-Review+2 Workflow+1

> Patch Set 1:
> 
> > Patch Set 1:
> > 
> > Generally this seems ok to me but I'm not sure if removing home is bad for future strict confinement? It seems home is the same as virtualenv. Maybe Dmitrii knows more about that.
> 
> Home sets the python path home, but within strict confinement the python interpreter and path is that used within the snap itself. All of the python bits are staged into the snap as a whole as system level packages. As such, I don't believe it impacts the future strict confinement work here.

That makes sense, thanks. Let's get this merged and unblock builds.

Patch-set: 1
Reviewer: Gerrit User 11805 <11805@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+2
Label: Workflow=+1

...

This commit is contained in:

Gerrit User 11805 2021-04-27 17:37:47 +00:00 committed by Gerrit Code Review

parent f6fdfdd34a

commit ac00c3340c

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available