Browse Source

Update patch set 2

Patch Set 2:

(1 comment)

> Patch Set 2: Code-Review-1
> 
> (1 comment)
> 
> I think we could use the native mechanism in glance (see the comment inline).
> 
> We could also disable proxy buffering so that "Transfer-Encoding: chunked" is handled better:
> 
> https://cloudblog.switch.ch/2015/08/10/buffering-issues-when-publishing-openstack-dashboard-and-api-services-behind-a-http-reverse-proxy/
> https://docs.openstack.org/glance/pike/admin/apache-httpd.html#mod-proxy-uwsgi
> 
> 
> Limiting the request size at the NGINX level would solve the problem but I would like to discuss the alternative first.

I think disabling the client_max_body_size is the simplest and most straightforward approach here. I don't see proxy configs in the nginx settings rendered by microstack today, so I think we should leave that for a future optimization.

Patch-set: 2
changes/83/783983/meta
Gerrit User 8992 5 months ago
committed by Gerrit Code Review
parent
commit
cb94ce747b
  1. 24
      1fce2529f68833fb4a5864d616134a51ef1d15f1

24
1fce2529f68833fb4a5864d616134a51ef1d15f1

@ -22,6 +22,30 @@
"revId": "1fce2529f68833fb4a5864d616134a51ef1d15f1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
},
{
"key": {
"uuid": "ab3cc7f7_7adb1727",
"filename": "snap-overlay/templates/nginx.conf.j2",
"patchSetId": 2
},
"lineNbr": 18,
"author": {
"id": 8992
},
"writtenOn": "2021-04-27T21:19:23Z",
"side": 1,
"message": "Rather than make it complicated, if we set client_max_body_size to 0 and effectively disable it we adopt the image_size_cap defaults in glance. This allows the user to configure it via glance config.",
"parentUuid": "6ad0fb75_cb791c6f",
"range": {
"startLine": 18,
"startChar": 0,
"endLine": 18,
"endChar": 51
},
"revId": "1fce2529f68833fb4a5864d616134a51ef1d15f1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}
Loading…
Cancel
Save