From f96a0f8123d5b459a1cc1624b4a40328822242b8 Mon Sep 17 00:00:00 2001 From: Billy Olsen Date: Tue, 11 Jan 2022 20:10:05 -0700 Subject: [PATCH] Revert django debug setting back to False Commit 4123da81 changed the innocuous DEBUG setting from True to False in the django local_settings for horizon. Unfortunately, the DEBUG flag is used by django in order to determine (among other things) whether or not to serve static files. This change reverts the DEBUG setting from False to True and adds breadcrumb comments for future travelers in oder to prevent this in the future. Closes-Bug: 1957696 Change-Id: I0bb57ce3f6b3ba124844267f2d9ae6ca35922d8c --- snap-overlay/templates/05_snap_tweaks.j2 | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/snap-overlay/templates/05_snap_tweaks.j2 b/snap-overlay/templates/05_snap_tweaks.j2 index e4e8805..416bf36 100644 --- a/snap-overlay/templates/05_snap_tweaks.j2 +++ b/snap-overlay/templates/05_snap_tweaks.j2 @@ -1,7 +1,11 @@ # Tweaks to make this run nicely in a snap. -# TODO: turn this off once everything is working nicely. -DEBUG = False +# TODO(wolsen): This should be turned off, but doing so will cause django +# to no longer serve static files by default. When turning this from True +# to False, django will need to be told to serve the static files or the +# nginx will need to be configured to serve these static files in order +# for things like css, js, and images to be retrievable. +DEBUG = True # Set our webroot. WEBROOT = '/'