51 lines
1.7 KiB
Plaintext
51 lines
1.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "6ad0fb75_cb791c6f",
|
|
"filename": "snap-overlay/templates/nginx.conf.j2",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 18,
|
|
"author": {
|
|
"id": 24824
|
|
},
|
|
"writtenOn": "2021-04-20T12:18:01Z",
|
|
"side": 1,
|
|
"message": "I propose we use image_size_cap instead:\n\nhttps://docs.openstack.org/glance/latest/configuration/configuring.html#configuring-glance-image-size-limit\n\nand set client_max_body_size to 0 (disabling it).\n\nhttps://nginx.org/en/docs/http/ngx_http_core_module.html#client_max_body_size\n\"Setting size to 0 disables checking of client request body size.\"",
|
|
"range": {
|
|
"startLine": 18,
|
|
"startChar": 0,
|
|
"endLine": 18,
|
|
"endChar": 51
|
|
},
|
|
"revId": "1fce2529f68833fb4a5864d616134a51ef1d15f1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "ab3cc7f7_7adb1727",
|
|
"filename": "snap-overlay/templates/nginx.conf.j2",
|
|
"patchSetId": 2
|
|
},
|
|
"lineNbr": 18,
|
|
"author": {
|
|
"id": 8992
|
|
},
|
|
"writtenOn": "2021-04-27T21:19:23Z",
|
|
"side": 1,
|
|
"message": "Rather than make it complicated, if we set client_max_body_size to 0 and effectively disable it we adopt the image_size_cap defaults in glance. This allows the user to configure it via glance config.",
|
|
"parentUuid": "6ad0fb75_cb791c6f",
|
|
"range": {
|
|
"startLine": 18,
|
|
"startChar": 0,
|
|
"endLine": 18,
|
|
"endChar": 51
|
|
},
|
|
"revId": "1fce2529f68833fb4a5864d616134a51ef1d15f1",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": true
|
|
}
|
|
]
|
|
} |