Update patch set 12

Patch Set 12: (6 comments) Patch-set: 12
2017-08-17 20:05:42 +00:00
parent cc180d6712
commit ad6cfa29dd
1 changed files with 124 additions and 0 deletions
--- a/124
+++ b/124
@@ -0,0 +1,124 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9f436f4f_d17e57ae",
+        "filename": "etc/mixmatch.conf.sample",
+        "patchSetId": 12
+      },
+      "lineNbr": 27,
+      "author": {
+        "id": 26123
+      },
+      "writtenOn": "2017-08-17T20:05:42Z",
+      "side": 1,
+      "message": "This is configured for my vm.\n\nAlso, it\u0027s not working",
+      "range": {
+        "startLine": 27,
+        "startChar": 8,
+        "endLine": 27,
+        "endChar": 48
+      },
+      "revId": "76f6ffc54396f50d1a0137eb545b42d55f466e40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f436f4f_3149238b",
+        "filename": "etc/mixmatch.conf.sample",
+        "patchSetId": 12
+      },
+      "lineNbr": 29,
+      "author": {
+        "id": 26123
+      },
+      "writtenOn": "2017-08-17T20:05:42Z",
+      "side": 1,
+      "message": "There is no output for this file.",
+      "range": {
+        "startLine": 29,
+        "startChar": 9,
+        "endLine": 29,
+        "endChar": 21
+      },
+      "revId": "76f6ffc54396f50d1a0137eb545b42d55f466e40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f436f4f_912fafa6",
+        "filename": "etc/mixmatch.conf.sample",
+        "patchSetId": 12
+      },
+      "lineNbr": 31,
+      "author": {
+        "id": 26123
+      },
+      "writtenOn": "2017-08-17T20:05:42Z",
+      "side": 1,
+      "message": "I turned debug on since there were cases of LOG.debug calls and I wanted to see if they were being printed.",
+      "range": {
+        "startLine": 31,
+        "startChar": 0,
+        "endLine": 31,
+        "endChar": 10
+      },
+      "revId": "76f6ffc54396f50d1a0137eb545b42d55f466e40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f436f4f_3117e354",
+        "filename": "mixmatch/config/default.py",
+        "patchSetId": 12
+      },
+      "lineNbr": 43,
+      "author": {
+        "id": 26123
+      },
+      "writtenOn": "2017-08-17T20:05:42Z",
+      "side": 1,
+      "message": "I\u0027ll fix this after this patch",
+      "revId": "76f6ffc54396f50d1a0137eb545b42d55f466e40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f436f4f_b102b30a",
+        "filename": "mixmatch/config/log_image.py",
+        "patchSetId": 12
+      },
+      "lineNbr": 0,
+      "author": {
+        "id": 26123
+      },
+      "writtenOn": "2017-08-17T20:05:42Z",
+      "side": 1,
+      "message": "I\u0027m thinking this redundancy can be avoided.\nThe main reason of this is to isolate each loggers from each other.",
+      "revId": "76f6ffc54396f50d1a0137eb545b42d55f466e40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f436f4f_2c11ca54",
+        "filename": "mixmatch/extend/__init__.py",
+        "patchSetId": 12
+      },
+      "lineNbr": 20,
+      "author": {
+        "id": 26123
+      },
+      "writtenOn": "2017-08-17T20:05:42Z",
+      "side": 1,
+      "message": "I didn\u0027t see LOG being used anywhere in the extended folder.\n\nThis now seems to me to be impulsive, I\u0027ll put it back next patch sorry.",
+      "revId": "76f6ffc54396f50d1a0137eb545b42d55f466e40",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}