x/mogan
Code Issues Proposed changes

objects: remove dict compat support from all XXXList() objects

Browse Source 
The XXXList() classes only ever have a single 'objects' attribute
and this is never directly accessed as a dict key, instead all
callers use it in list context. Thus the dict compat support can
be removed from all these objects

Change-Id: I3f8d49d25b99dd0a498dfaad705c6332908cb72f
This commit is contained in:
Daniel P. Berrange
2014-12-12 11:04:07 +00:00
parent e4f5b52722
commit 54878b01c5
4 changed files with 4 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
nova/objects/aggregate.py
View File

@@ -149,9 +149,7 @@ class Aggregate(base.NovaPersistentObject, base.NovaObject,
return self.metadata.get('availability_zone', None)
# TODO(berrange): Remove NovaObjectDictCompat
class AggregateList(base.ObjectListBase, base.NovaObject,
base.NovaObjectDictCompat):
class AggregateList(base.ObjectListBase, base.NovaObject):
# Version 1.0: Initial version
# Version 1.1: Added key argument to get_by_host()
# Aggregate <= version 1.1

4
nova/objects/instance_fault.py
View File

@@ -89,9 +89,7 @@ class InstanceFault(base.NovaPersistentObject, base.NovaObject,
LOG.exception(_LE("Failed to notify cells of instance fault"))
# TODO(berrange): Remove NovaObjectDictCompat
class InstanceFaultList(base.ObjectListBase, base.NovaObject,
base.NovaObjectDictCompat):
class InstanceFaultList(base.ObjectListBase, base.NovaObject):
# Version 1.0: Initial version
# InstanceFault <= version 1.1
# Version 1.1: InstanceFault version 1.2

4
nova/objects/instance_group.py
View File

@@ -196,9 +196,7 @@ class InstanceGroup(base.NovaPersistentObject, base.NovaObject,
return len(instances)
# TODO(berrange): Remove NovaObjectDictCompat
class InstanceGroupList(base.ObjectListBase, base.NovaObject,
base.NovaObjectDictCompat):
class InstanceGroupList(base.ObjectListBase, base.NovaObject):
# Version 1.0: Initial version
# InstanceGroup <= version 1.3
# Version 1.1: InstanceGroup <= version 1.4

4
nova/objects/keypair.py
View File

@@ -65,9 +65,7 @@ class KeyPair(base.NovaPersistentObject, base.NovaObject,
db.key_pair_destroy(context, self.user_id, self.name)
# TODO(berrange): Remove NovaObjectDictCompat
class KeyPairList(base.ObjectListBase, base.NovaObject,
base.NovaObjectDictCompat):
class KeyPairList(base.ObjectListBase, base.NovaObject):
# Version 1.0: Initial version
# KeyPair <= version 1.1
VERSION = '1.0'