f8da8f4f31
Patch Set 1: Code-Review-1 (11 comments) Just a couple of things also would be really interesting to see it run in a cluster environment Patch-set: 1 Label: Code-Review=-1
191 lines
5.2 KiB
Plaintext
191 lines
5.2 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_88118c06",
|
|
"filename": "smoke2.yml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 5,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "take out single node variant",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_0867dcb7",
|
|
"filename": "smoke2.yml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 6,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "instead of using the hostvars should we use a ansible variable set to the IP? also make sure the dbtype is being set to the correct db type",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_48f834c3",
|
|
"filename": "tests/cli_wrapper.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 12,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "delete extra space",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_68b3f050",
|
|
"filename": "tests/cli_wrapper.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 66,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "did you want to print out the notification id?",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_48cdd483",
|
|
"filename": "tests/smoke2.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 36,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "does this default to influxdb?",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_089a3c6e",
|
|
"filename": "tests/smoke2.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 48,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "-i here? should be db",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_2ef501ec",
|
|
"filename": "tests/smoke2.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 258,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "we should have the password and the username in the config file",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_08447cb4",
|
|
"filename": "tests/smoke2.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 278,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "the project needs to be configurable as well",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_88eaac72",
|
|
"filename": "tests/smoke2.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 316,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "just a heads up these ports will only be on the master or children nodes in a cluster environment not both. something to think of",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_e898001e",
|
|
"filename": "tests/smoke2.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 384,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "default to influxdb",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3afb71cf_887e2c68",
|
|
"filename": "tests/smoke_configs.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 73,
|
|
"author": {
|
|
"id": 15027
|
|
},
|
|
"writtenOn": "2015-06-10T15:12:26Z",
|
|
"side": 1,
|
|
"message": "reason for adding comma?",
|
|
"revId": "87c8965cb48122b5d4e0c85e3fc20906b8de1fba",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |