From 8c430edca0ef43751bee78f83f4245885ca1b2cc Mon Sep 17 00:00:00 2001
From: Major Hayden <major@mhtx.net>
Date: Thu, 9 Mar 2017 10:40:02 -0600
Subject: [PATCH] Improve tests for formatters (#8)

This should give us full test coverage for the formatter plugins.
---
 tests/test_formatters.py | 38 ++++++++++++++++++++++++++++++++++++--
 1 file changed, 36 insertions(+), 2 deletions(-)

diff --git a/tests/test_formatters.py b/tests/test_formatters.py
index 2962436..e25c53b 100644
--- a/tests/test_formatters.py
+++ b/tests/test_formatters.py
@@ -13,7 +13,6 @@
 # limitations under the License.
 """Tests the output methods."""
 import json
-import platform
 
 from monitorstack.common import formatters
 
@@ -22,13 +21,31 @@ SAMPLE_RESULT = {
     'message': 'uptime is ok',
     'measurement_name': 'system_uptime',
     'meta': {
-        'platform': platform.platform(),
+        'platform': 'example_platform',
     },
     'variables': {
         'uptime': '29587.75'
     }
 }
 
+SAMPLE_RESULT_NO_META = {
+    'exit_code': 0,
+    'message': 'uptime is ok',
+    'measurement_name': 'system_uptime',
+    'variables': {
+        'uptime': '29587.75'
+    }
+}
+
+SAMPLE_RESULT_NO_META_WITH_FLOAT = {
+    'exit_code': 0,
+    'message': 'uptime is ok',
+    'measurement_name': 'system_uptime',
+    'variables': {
+        'uptime': float(29587.75)
+    }
+}
+
 
 class TestFormatters(object):
     """Tests for the base cli module."""
@@ -61,3 +78,20 @@ class TestFormatters(object):
         formatters.write_telegraf(SAMPLE_RESULT)
         out, err = capsys.readouterr()
         assert out.startswith(SAMPLE_RESULT['measurement_name'])
+
+    def test_write_telegraf_without_meta(self, capsys):
+        """Test write_telegrat() module without meta in result."""
+        formatters.write_telegraf(SAMPLE_RESULT_NO_META)
+        out, err = capsys.readouterr()
+        assert out.startswith(SAMPLE_RESULT['measurement_name'])
+
+    def test_write_telegraf_line_format_with_float(self):
+        """Test _telegraf_line_format() with float in meta."""
+        sets = {
+            'platform': 'example_platform',
+            'othervar': float(3)
+        }
+        result = formatters._telegraf_line_format(sets=sets, quote=True)
+        assert isinstance(result, str)
+        assert 'othervar=3' in result
+        assert 'platform="example_platform"' in result