Commit Graph

78 Commits (cc0b186a9c211cf0a5007ac6d9fee2896c56f0ab)

Author SHA1 Message Date
Henry Gessau 73c856dec4 Import oslo_messaging instead of oslo.messaging
This fixes the unit tests.

To get jenkins to pass we also need to comment out the migration
check for pep8 temporarily. This check will be re-enabled with

Change-Id: If8484812e7cd026727b920fa70182db23154df58
8 years ago
armando-migliaccio d4f5606c0e Switch to new oslo library names
Change-Id: Icea55acb2b7ff8bc3374791ac5f030fb17b4a066
8 years ago
armando-migliaccio cbeb47ba42 Fix import errors
Change-Id: I4d01af55904408692e991784ebab5de11cc1014a
8 years ago
Jenkins cec580debc Merge "Fix for multiple entries in ucast_mac_remote" 8 years ago
vikas 5d4a4ad790 Fix for multiple entries in ucast_mac_remote
checking mac and logical switch while creating l2-gateway-connection,
if there is entry in ucast_mac_remote for second l2-gateway-connection for
same logical switch.
taken care of deleting ucast_mac_remote and vlan_bindings
while deleting l2-gateway-connection.


Co-Authored-By: Phani Pawan <>
Co-Authored-By: MANJUNATH PATIL <>

Change-Id: Id9205c902210d94d7168eb95fbd6c3520fbb6239
8 years ago
vikas eaf54d893a Fix for internal server error
internal server error occurs if empty l2gateway is passed in checking the the same.

Closes-Bug: 1454670

Change-Id: I5faba8d5e097b5ca8aeec44b7fde0a61d98486e4
8 years ago
Phani Pawan a58a8d800d Fix for writing correct ovsdb identifier
This patchset fixes the bug which causes wrong
ovsdb identifier to be updated in mysql

Change-Id: Iba87f86ca73a0a467b673dc78a2df954c76654b0
Closes-bug: 1456074
8 years ago
vikas 455819f581 checking the order in update l2gateway
checking the correct order of device and interfaces
while updating l2gateway.

Change-Id: I71507b7d18898fb19efa48ce766319c8792fd3e4
Closes-Bug: 1454650
8 years ago
Manjunath Patil b9982add08 Recreation of tunnels and exception handling when adding vm port
The patch set handles recreation of tunnels
when openvswitch is restarted and it also proposes
the fix for exception thrown while adding vm port
after l2gateway connection to ovsdb


Change-Id: I3ccdd64272adc2d008da69fdd2652b029368fb44
Co-Authored-By: Phani Pawan <>
8 years ago
Jenkins e9fcce303e Merge "Support for specifying segmentation id optional" 8 years ago
Selvakumar S 8d6cb1b3f3 Support for specifying segmentation id optional
This fix for supporting the '0' segmentation id during l2gateway connection create.
This is applied for the use case where some bare metal server can not handle tagged packets(connected to access ports)


Change-Id: Ia92432f0296152116e998ad8418c35ef014f898e
8 years ago
Jenkins 7d84b6b057 Merge "Retry logic for insert/delete/update MAC failures" 8 years ago
Maruti bb70491207 Retry logic for insert/delete/update MAC failures
The patch set fixes the problem described in a launchpad
bug, where any failures in inserting/updating/delete MACs
into the OVSDB server do not get retried in a later
point in time. The failure may occur when the L2 gateway
agent is down or the OVSDB server is down.

Change-Id: I79956f498c3279e1c78be812563a32c2c41e77ca
Closes-Bug: 1446805
Closes-Bug: 1451765
8 years ago
preeti-mirji e666dbac1e Deactivating the switch doesnot delete l2gw-conn
This patchset addresses the changes where deactivating
switch/ovsdb should delete l2-gateway-connections.

Change-Id: I8be62153e24696c4b265b7634ab172fbd4a2bda5
Closes-bug: 1447453
8 years ago
preeti-mirji 92c23cf734 L2gw connection fails for invalid device/interface
Creating l2-gateway-connection gives internal
server error if invalid device or invalid interface
is specified.

Change-Id: I5a738b085400b3937dd4f03076233853d05133d0
Closes-bug: 1447467
8 years ago
Jenkins 0bcf76400e Merge "L2gw to support VM migration" 8 years ago
Maruti ecbb9204ee Fix for reading large data from OVSDB server
The patch set fixes the problem described in the launchpad
bug 1447571, where the L2 gateway agent does not populate
OVSDB related tables in the neutron DB, when the data is large.

Change-Id: Ifdd9dacc2419ce427e9526d4e2e4298291a531cc
Closes-Bug: 1447571
8 years ago
Jenkins 24911b9973 Merge "Constraint violation error of physical locator" 8 years ago
Jenkins 06dca46604 Merge "connection-create/delete to report correct error" 8 years ago
Phani Pawan 2c415cc049 Constraint violation error of physical locator
This patch fixes the physical locator dict which was
being passed to the agent during the second
l2gateway connection

Change-Id: I0670ff18c855e5ea045e0047227c2dbe044d91ce
8 years ago
Maruti d5e023d362 connection-create/delete to report correct error
The patch set fixes the problem described in the launchpad
bug 1446218 where l2-gateway-connection-create and
l2-gateway-connection-delete report internal server error
instead of correct error that will hint the user to
the right problem area.

Change-Id: I329a4b36ea26482bf69a4afe2a1e0b1271f752ec
Closes-Bug: 1446218
8 years ago
Maruti 60aab17a98 Fix for l2-gateway-connection-delete error
The patch set fixes the problem described in launchpad
bug 1445770 where l2-gateway-connection-delete reports
an error when there are VMs on the network associated
with the connection.

Closes-Bug: 1445770

Change-Id: I76278bda7bfbd3cc997166ca13f985878e06a5cd
8 years ago
Maruti ed895ebcef L2gw to support VM migration
The patch set handles VM migration usecase for
L2GW. Basically, it updates Ucast_Macs_Remote
table record for the port associated with the
VM being migrated and inserts new entry in
Physical_Locators table if that locator does not


Co-Authored-By: Koteswara Rao Kelam <>
Change-Id: Icf1a973cd3e3ac5e889c7a63405471062f1f9a0d
8 years ago
Manjunath Patil 4081add0b8 Fix for L2Gateway fails if OVSDB has pre-populated

The patch set fixes the problem described in the launchpad
bug 1445323 where all the OVSDB tables in MYSQL DB should
be populated correctly.

Change-Id: I753b665de93d3e924bf23cbe8fb736410cb4bc73
Closes-Bug: 1445323
8 years ago
Maruti e59678f490 MAC address of VM not getting populated in OVSDB
The patch set fixes the problem described in the launchpad
bug 1445153, where the L2 gateway service plugin was getting
an error while inserting VM MAC address into the OVSDB server
when a new VM is booted on a network for which l2-gateway
connection exists.

Change-Id: I7e84a91f6e37c4bf557f8536b95b91f4a08f427c
Closes-Bug: 1445153
8 years ago
Manjunath Patil f3ceaa4b40 Fix for OVSDB and Neutron (MYSQL) Tables
are not in Sync

The patch set fixes the problem described in the launchpad
bug 1444833 where the agent sends physical_switch_id is sent as None
to plugin as a part of update_ovsdb_changes rpc

Change-Id: I1a5f087eac4df8d39326ae344afe2fd4b159fc70
Closes-Bug: 1444833
8 years ago
Selvakumar S 260027afa6 Exception priority moved ahead for L2GW not found
High priority  Exception like L2GatewayNotFound, L2GatewayConnectionExists, NetworkNotFound etc are
moved ahead of segmentation id related exceptions

Change-Id: I583031616c2074c2c18a3917abffae9b55c30b84
8 years ago
Maruti 3d77e4a635 Validation of duplicate segmentation ID
The patch set fixes the problem described in the launchpad
bug 1443387 where the L2 gateway service plugin was not
checking whether the segmentation ID specified in the
l2-gateway-connection-create operation is already present in the
interface's VXLAN-to-VLAN binding.

Closes-Bug: 1443387
Change-Id: I42a170c479600ce0f45ba3620e665562b6af9b98
8 years ago
Jenkins 77ea0ad892 Merge "Fix for the launchpad bug 1440649" 8 years ago
Jenkins 540faed8f0 Merge "ucast_macs and physical_locators deletion problem" 8 years ago
Maruti c462a30ecc l2-gateway-connection-create reports OVSDBError
The patch set fixes
1. a problem described in the
bug 1440301 where the L2gateway agent throws
a syntax error as the logical switch is passed
as a list inside a list.
2. a problem where the database model
cannot store the value of the string
"unspecified-fault" in 16 character column width
for the port fault status and switch fault status.
3. a problem where the L2gateway agent and the plugin
do not handle empty port and switch fault status
which makes validation of the logical gateway fail
when an l2-gateway-connection is created.

Change-Id: Id4530b26407f2a6d57de7254476d77a36bb70a27
8 years ago
Maruti 9aa9b2153a Fix for the launchpad bug 1440649
The patch set fixes the problem described
in the launchpad bug 1440649 where deletion
of an existing l2gw connection fails.
The code logic in the service plugin (inside
the method delete_port_mac) handled
the case where the incoming argument was a dict.
It, however, did not handle the case where
the incoming argument was a list.

Closes-Bug: 1440649
Change-Id: Id315416b12b6af581aa768c1378fae6496c342f5
8 years ago
Maruti e31d4a80e8 ucast_macs and physical_locators deletion problem
The patch set fixes the problem described in
the launchpad bug 1440691 where the plugin
was not able to delete entries from
ucast_macs_remotes and physical_locators
tables when l2-gateway-connection-delete deletes
the entries from the corresponding OVSDB
server tables, and the OVSDB server sends
delete notifications to the plugin via
the L2gw agent.

Closes-Bug: 1440691
Change-Id: Ib5e18f7a278f2e8d13d5fc271826599c49b141e7
8 years ago
Jenkins d80b1c8ecd Merge "port_fault_status and switch_fault_status" 8 years ago
Jenkins 07ef48da5b Merge "Re-reading OVSDB data when agent heart beats fail" 8 years ago
vikas 91214d2bc7 port_fault_status and switch_fault_status
port_fault_status and switch_fault_status implementation.
reflect the same status in neutron db from ovsdb.
raises appropriate error message while creating l2gateway connection
if switch_fault_status and port_fault_status is not UP.

Change-Id: Icc77392afeb62bd2b0b0b816a63f8f02b442b0d8
8 years ago
Phani Pawan d670ffe775 Difference in RPC arguments l2gateway Plugin
and l2gateway Agent

This patchset addresses the changes related
to L2gateway Plugin RPC arguments which
should be in par with the L2gateway agent


Change-Id: I478b008a6ec7045c0d9a38d43f12a7ab3913447b
Co-Authored-By: Manjunath Patil <>
8 years ago
Maruti 3199bb6785 Re-reading OVSDB data when agent heart beats fail
The patch set converts the Monitor L2gateway agent to the
transact agent when the Neutron server is disconnected
from the Rabbit MQ bus, and the L2gateway Monitor agent
is not able to report its state to the Neutron server.
When the Neutron server connects back to the bus, it selects
a particular agent as the Monitor agent and the OVSDB server
data is re-read so as to get the up-to-date view of the data.

Change-Id: Idd662d35ffee8e91cba7800b88d27359f3d98138
8 years ago
Manjunath Patil 73ffa7e0cd L2 gateway Connection create fails with UnBoundLocalError
where 'logical_switch_uuid' referenced before assignment

Change-Id: I57dfe0b89821f6573f297362ce13a133e6ff34bd
8 years ago
Jenkins fcb9405a72 Merge "Making l2gateway connection-create/delete reliable" 8 years ago
Jenkins 0adf8a7d6e Merge "Making deletion of MACs from OVSDB faster" 8 years ago
Maruti ef6fd2c22d Making deletion of MACs from OVSDB faster
This patch set fixes a problem where the plugin
was sending multiple RPCs for deleting a bunch
of MAC addresses from the OVSDB table which
resulted in multiple RPCs back to the plugin
from the Monitor agent.
The patch set allows a list of MAC addresses
in the RPC.

Co-Authored-By: Phani Pawan <>
Co-Authored-By: Manjunath Patil <>

Change-Id: I47b8c23751c1bcea4c1fb2f79000f2d9ba55d5b0
8 years ago
Maruti c9b16d7529 Making l2gateway connection-create/delete reliable
The patch set makes l2gateway connection-create/delete reliable
end-to-end. Any error that occurs on the agent/OVSDB side gets
propagated to the server.
To achieve this, cast has been changed to call for the
rpc update_connection_to_gateway.

Change-Id: I691695acefd9ebdf56d24d509bfd0593fc1bbd30
8 years ago
Manjunath Patil 10b35464c4 Fix for NoneType Exeception handling
Change-Id: Ia926dc44b0c5ead576fac4f9baaed75baf1a5105
8 years ago
Selvakumar S ca3565deba L2 gateway connection creation is fails
where _get_network_segments passes extra parameters in plugin

Change-Id: If24a7ef4e220203d28c8a545e1bf20721fb10985
8 years ago
vikas a1338e224b Changing the log imports
Changing the log imports from
neutron.openstack.common import log to
oslo_log import log, due to change in latest neutron.

Change-Id: Ic7de94602feb088005f0b61e7d7963dde35a8ac0
8 years ago
Jenkins 5b64ccdaa4 Merge "README for L2gw to OVSDB communication alternative" 8 years ago
Phani Pawan 4bb2002edc L2Gateway Service Plugin RPC Implementation
This patch set implements RPC calls that are initiated by the
L2 gateway agent destined to the L2 gateway service plugin

Change-Id: Id60565dca791cf0b104bb8d85a9b3c4c7b4537d7
Author: Phani Pawan <>
Co-Authored-By: Manjunath Patil <>
8 years ago
Maruti 213d8c1e3d README for L2gw to OVSDB communication alternative
The patch set contains the README file that describes about
other alternative using OpenvSwitch IDL class which the L2
gateway agent could use to communicate with OVSDB server.

Change-Id: Iadf9683cbcb3fab942fce22024b595d03a8e05f2
8 years ago
Maruti 3948b0dd63 L2gateway agent writing to and reading from OVSDB
The patch set contains the code of the L2
gateway agent that writes into OVSDB tables
and processes events that come from the
OVSDB server whenever the OVSDB data changes.

Change-Id: I49f9350f11a2b7fb69b8b7b0eae3138bb1159522
8 years ago