Update patch set 7

Patch Set 7: Code-Review-1 (27 comments) Patch-set: 7 Label: Code-Review=-1
2018-06-11 10:10:15 +00:00
parent cce10a5d24
commit 23df3936a5
1 changed files with 360 additions and 0 deletions
--- a/360
+++ b/360
@@ -0,0 +1,360 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "5f7c97a3_e679f181",
+        "filename": "neutron_classifier/common/eth_validators.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "I\u0027d like to get Bernard\u0027s opinion on this.\nOriginally these validator files were going to check if the various classification type creations were sane classifications.\nHowever I think we said we wanted to stay away from validating the classifications early on.\nDo you think we should keep the validators (which we\u0027ll need to populate with checks for each field of each classification type) or remove them?",
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_469a2514",
+        "filename": "neutron_classifier/common/eth_validators.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 18,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Update to use the values in: https://review.openstack.org/#/c/499571/35/neutron_classifier/objects/classifications.py",
+      "range": {
+        "startLine": 15,
+        "startChar": 20,
+        "endLine": 18,
+        "endChar": 34
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_e60fb136",
+        "filename": "neutron_classifier/common/exceptions.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 39,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "These can be removed, I don\u0027t think they\u0027re used anywhere else in the code.",
+      "range": {
+        "startLine": 22,
+        "startChar": 0,
+        "endLine": 39,
+        "endChar": 51
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_0952fd67",
+        "filename": "neutron_classifier/common/exceptions.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 75,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "These Exceptions are not used in the code, they might be carried over from previous iterations that have since been updated.",
+      "range": {
+        "startLine": 42,
+        "startChar": 0,
+        "endLine": 75,
+        "endChar": 65
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_06a0ad41",
+        "filename": "neutron_classifier/common/ipv4_validators.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 26,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Ditto",
+      "range": {
+        "startLine": 15,
+        "startChar": 19,
+        "endLine": 26,
+        "endChar": 38
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_868b5dbe",
+        "filename": "neutron_classifier/common/ipv6_validators.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 21,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Ditto",
+      "range": {
+        "startLine": 15,
+        "startChar": 19,
+        "endLine": 21,
+        "endChar": 34
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_e657b159",
+        "filename": "neutron_classifier/common/resources.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 16,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Maybe we should avoid using attr here, at least to me it has implications of having something to do with the database.\nMaybe just change it to const instead.",
+      "range": {
+        "startLine": 16,
+        "startChar": 27,
+        "endLine": 16,
+        "endChar": 44
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_e13c7b93",
+        "filename": "neutron_classifier/common/resources.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 52,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Nit: Should this be plural?\nIf it is, it\u0027l need to be changed throughout the code (Mainly the 2 files that make up the service plugins).",
+      "range": {
+        "startLine": 52,
+        "startChar": 5,
+        "endLine": 52,
+        "endChar": 19
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_0142d70f",
+        "filename": "neutron_classifier/common/resources.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 56,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Ditto",
+      "range": {
+        "startLine": 56,
+        "startChar": 5,
+        "endLine": 56,
+        "endChar": 10
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_e1c79b97",
+        "filename": "neutron_classifier/common/resources.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 58,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "This should be a list",
+      "range": {
+        "startLine": 58,
+        "startChar": 39,
+        "endLine": 58,
+        "endChar": 41
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_26be0965",
+        "filename": "neutron_classifier/common/tcp_validators.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 21,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Ditto",
+      "range": {
+        "startLine": 15,
+        "startChar": 19,
+        "endLine": 21,
+        "endChar": 37
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_e6b33199",
+        "filename": "neutron_classifier/common/udp_validators.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 18,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Ditto",
+      "range": {
+        "startLine": 15,
+        "startChar": 19,
+        "endLine": 18,
+        "endChar": 37
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_0158972e",
+        "filename": "neutron_classifier/db/classification.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 25,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Change Db to Group, Originally Db was used because the group commands had a lot more interaction with the Db than the other parts of the service plugin, however it would be more accurate to call it the TrafficClassificationGroupPlugin.",
+      "range": {
+        "startLine": 25,
+        "startChar": 27,
+        "endLine": 25,
+        "endChar": 29
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_21f03367",
+        "filename": "neutron_classifier/db/classification.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 54,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Does this and line 38 do different things?",
+      "range": {
+        "startLine": 52,
+        "startChar": 0,
+        "endLine": 54,
+        "endChar": 43
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_89cb6d1c",
+        "filename": "neutron_classifier/extensions/classification.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 104,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "neutron_classifier.common.constants.L2_PREFIX doesn\u0027t exist, we should add it there or check if it\u0027s in Neutron_lib.",
+      "range": {
+        "startLine": 104,
+        "startChar": 18,
+        "endLine": 104,
+        "endChar": 37
+      },
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5f7c97a3_c9dc05e3",
+        "filename": "tox.ini",
+        "patchSetId": 7
+      },
+      "lineNbr": 1,
+      "author": {
+        "id": 18051
+      },
+      "writtenOn": "2018-06-11T10:10:15Z",
+      "side": 1,
+      "message": "Apply the changes in: https://review.openstack.org/#/c/573930/1",
+      "revId": "6020af463bb547743f03f254335b2fcf57c9f8b2",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}