x
/
neutron-classifier
Code Issues Proposed changes

Update patch set 4 

Patch Set 4:

For the pep8 failure see [1]. For projects that build docs, you should add a requirements.txt to the docs/ directory that specifies the doc based requirements (for example [2])... If you don't build docs you dont need it, but then don't reference it in the tox.ini.



For the tox-docs failure, it maybe related to not using the proper sphinx packages. I'd ensure you have the proper docs packages specified, for example [2].



For release notes build failure; if the project is going to use release notes (don't have to since it's not an openstack formal project) then the releasenotes dir needs to be setup and the proper dependencies included in the test-requirements. For example layout see [4]. The releasenotes/notes/ dir is where the actual release notes get created when you add them using reno [5]. Maybe you can leave the release notes build out for now and add it later to simplify things in this patch?




[1] http://logs.openstack.org/19/671319/4/check/openstack-tox-pep8/10adc78/job-output.txt.gz#_2019-07-17_16_12_34_532682
[2] https://opendev.org/x/vmware-nsx/src/branch/master/doc/requirements.txt
[3] http://logs.openstack.org/19/671319/4/check/build-openstack-releasenotes/1cf745d/job-output.txt.gz#_2019-07-17_16_11_49_342191
[4] https://opendev.org/x/vmware-nsx/src/branch/master/releasenotes
[5] https://docs.openstack.org/reno/latest/user/usage.html#creating-new-release-notes

Patch-set: 4
This commit is contained in:
Gerrit User 5367 2019-07-17 20:24:39 +00:00 committed by Gerrit Code Review
parent d87ed8ea1f
commit 3bb84a86c9
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available