Update patch set 8

Browse Source

Patch Set 8: Code-Review+1

The comments look fine.  Thank you.

> 503 will NEVER changed, it's http spec

I realize that.  I chaired W3C working groups creating REST protocols, so I've spent months understanding HTTP in theory and in practice.  I know many of the related RFCs by number, some by chapter.  I've written proposals for HTTP headers, that have been accepted (example: Accept-Post) by the IETF.

> maybe we will add more reason but I am really not sure others might be added soon

As I've already said, you *could* add 500 as a retry today and it would make perfect sense given HTTP's semantics for it; doing so would be more complete and no less correct.  *When*, if ever, we actually feel enough need to spend the code/test effort to do that is a separate question.  If we're not seeing many 500's today, which I think is the case, I'm completely fine investing elsewhere for now.

Patch-set: 8
Reviewer: Gerrit User 14658 <14658@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1

...

This commit is contained in:

Gerrit User 14658

2017-03-15 15:51:09 +00:00

committed by Gerrit Code Review

parent 078f8a3d71

commit 57afa6131e

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

Diff Content Not Available